From 5384ceacc3fa2609d5b64ee005dee554656f8836 Mon Sep 17 00:00:00 2001 From: John Ericson Date: Thu, 23 May 2024 11:28:25 -0400 Subject: [PATCH] Document field being initialized in `Machine` constructor --- src/libstore/machines.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/libstore/machines.cc b/src/libstore/machines.cc index b4df658b1..20f24e883 100644 --- a/src/libstore/machines.cc +++ b/src/libstore/machines.cc @@ -168,14 +168,24 @@ static Machine parseBuilderLine(const std::set & defaultSystems, co if (!isSet(0)) throw FormatError("bad machine specification: store URL was not found at the first column of a row: '%s'", line); + // TODO use designated initializers, once C++ supports those with + // custom constructors. return { + // `storeUri` tokens[0], + // `systemTypes` isSet(1) ? tokenizeString>(tokens[1], ",") : defaultSystems, + // `sshKey` isSet(2) ? tokens[2] : "", + // `maxJobs` isSet(3) ? parseUnsignedIntField(3) : 1U, + // `speedFactor` isSet(4) ? parseFloatField(4) : 1.0f, + // `supportedFeatures` isSet(5) ? tokenizeString>(tokens[5], ",") : std::set{}, + // `mandatoryFeatures` isSet(6) ? tokenizeString>(tokens[6], ",") : std::set{}, + // `sshPublicHostKey` isSet(7) ? ensureBase64(7) : "" }; }