From 19c43c5d787c113053ef651c3d22fdfde61075e2 Mon Sep 17 00:00:00 2001
From: John Ericson <John.Ericson@Obsidian.Systems>
Date: Tue, 25 Jul 2023 11:44:39 -0400
Subject: [PATCH] Write test for deleting objects referenced from below

Currently fails, as expected.
---
 tests/hermetic.nix                        |  4 +--
 tests/overlay-local-store/delete-inner.sh | 39 +++++++++++++++++++++++
 tests/overlay-local-store/delete.sh       |  5 +++
 tests/overlay-local-store/local.mk        |  1 +
 4 files changed, 47 insertions(+), 2 deletions(-)
 create mode 100644 tests/overlay-local-store/delete-inner.sh
 create mode 100755 tests/overlay-local-store/delete.sh

diff --git a/tests/hermetic.nix b/tests/hermetic.nix
index 4c9d7a51f..c4fbbfa14 100644
--- a/tests/hermetic.nix
+++ b/tests/hermetic.nix
@@ -37,7 +37,7 @@ let
     buildCommand = ''
       echo hi-input3
       read x < ${input2}
-      echo $x BAZ > $out
+      echo ${input2} $x BAZ > $out
     '';
   };
 
@@ -51,6 +51,6 @@ in
       ''
         read x < ${input1}
         read y < ${input3}
-        echo "$x $y" > $out
+        echo ${input1} ${input3} "$x $y" > $out
       '';
   }
diff --git a/tests/overlay-local-store/delete-inner.sh b/tests/overlay-local-store/delete-inner.sh
new file mode 100644
index 000000000..0702d1693
--- /dev/null
+++ b/tests/overlay-local-store/delete-inner.sh
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+set -eu -o pipefail
+
+source common.sh
+
+# Avoid store dir being inside sandbox build-dir
+unset NIX_STORE_DIR
+unset NIX_STATE_DIR
+
+storeDirs
+
+initLowerStore
+
+mountOverlayfs
+
+export NIX_REMOTE="$storeB"
+stateB="$storeBRoot/nix/var/nix"
+hermetic=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg seed 2)
+input1=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg seed 2 -A passthru.input1 -j0)
+input2=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg seed 2 -A passthru.input2 -j0)
+input3=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg seed 2 -A passthru.input3 -j0)
+
+# Can't delete because referenced
+expectStderr 1 nix-store --delete $input1 | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --delete $input2 | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --delete $input3 | grepQuiet "Cannot delete path"
+
+# These same paths are referenced in the lower layer (by the seed 1
+# build done in `initLowerStore`).
+expectStderr 1 nix-store --store "$storeA" --delete $input2 | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --store "$storeA" --delete $input3 | grepQuiet "Cannot delete path"
+
+# Can delete
+nix-store --delete $hermetic
+
+# Now unreferenced in upper layer, can delete
+nix-store --delete $input3
+nix-store --delete $input2
diff --git a/tests/overlay-local-store/delete.sh b/tests/overlay-local-store/delete.sh
new file mode 100755
index 000000000..79d67da71
--- /dev/null
+++ b/tests/overlay-local-store/delete.sh
@@ -0,0 +1,5 @@
+source common.sh
+
+requireEnvironment
+setupConfig
+execUnshare ./delete-inner.sh
diff --git a/tests/overlay-local-store/local.mk b/tests/overlay-local-store/local.mk
index 1f8de8f27..c9cb0b7f2 100644
--- a/tests/overlay-local-store/local.mk
+++ b/tests/overlay-local-store/local.mk
@@ -4,6 +4,7 @@ overlay-local-store-tests := \
   $(d)/build.sh \
   $(d)/bad-uris.sh \
   $(d)/add-lower.sh \
+  $(d)/delete.sh \
   $(d)/gc.sh \
   $(d)/verify.sh \
   $(d)/optimise.sh