From 4ff7f5aa9cf15a3c8922ecb2c52875f4f8672899 Mon Sep 17 00:00:00 2001
From: HaeNoe <programmierhaenoe@outlook.de>
Date: Tue, 16 Apr 2024 13:26:20 +0200
Subject: [PATCH] refactor `fetchers::PublicKey` tests

---
 .../data/public-key/defaultType.json          |  4 ++
 .../libfetchers/data/public-key/simple.json   |  4 ++
 tests/unit/libfetchers/public-key.cc          | 45 +++++++++++++++----
 3 files changed, 44 insertions(+), 9 deletions(-)
 create mode 100644 tests/unit/libfetchers/data/public-key/defaultType.json
 create mode 100644 tests/unit/libfetchers/data/public-key/simple.json

diff --git a/tests/unit/libfetchers/data/public-key/defaultType.json b/tests/unit/libfetchers/data/public-key/defaultType.json
new file mode 100644
index 000000000..43f02a420
--- /dev/null
+++ b/tests/unit/libfetchers/data/public-key/defaultType.json
@@ -0,0 +1,4 @@
+{
+  "key": "ABCDE",
+  "type": "ssh-ed25519"
+}
diff --git a/tests/unit/libfetchers/data/public-key/simple.json b/tests/unit/libfetchers/data/public-key/simple.json
new file mode 100644
index 000000000..f83b927ac
--- /dev/null
+++ b/tests/unit/libfetchers/data/public-key/simple.json
@@ -0,0 +1,4 @@
+{
+  "key": "ABCDE",
+  "type": "ssh-rsa"
+}
diff --git a/tests/unit/libfetchers/public-key.cc b/tests/unit/libfetchers/public-key.cc
index fcd5c3af0..941ae9db7 100644
--- a/tests/unit/libfetchers/public-key.cc
+++ b/tests/unit/libfetchers/public-key.cc
@@ -1,18 +1,45 @@
 #include <gtest/gtest.h>
 #include "fetchers.hh"
 #include "json-utils.hh"
+#include <nlohmann/json.hpp>
+#include "tests/characterization.hh"
 
 namespace nix {
-    TEST(PublicKey, jsonSerialization) {
-        auto json = nlohmann::json(fetchers::PublicKey { .key = "ABCDE" });
 
-        ASSERT_EQ(json, R"({ "key": "ABCDE", "type": "ssh-ed25519" })"_json);
-    }
-    TEST(PublicKey, jsonDeserialization) {
-        auto pubKeyJson = R"({ "key": "ABCDE", "type": "ssh-ed25519" })"_json;
-        fetchers::PublicKey pubKey = pubKeyJson;
+using nlohmann::json;
 
-        ASSERT_EQ(pubKey.key, "ABCDE");
-        ASSERT_EQ(pubKey.type, "ssh-ed25519");
+class PublicKeyTest : public CharacterizationTest
+{
+    Path unitTestData = getUnitTestData() + "/public-key";
+
+public:
+    Path goldenMaster(std::string_view testStem) const override {
+        return unitTestData + "/" + testStem;
     }
+};
+
+#define TEST_JSON(FIXTURE, NAME, VAL)                                     \
+    TEST_F(FIXTURE, PublicKey_ ## NAME ## _from_json) {                   \
+        readTest(#NAME ".json", [&](const auto & encoded_) {              \
+            fetchers::PublicKey expected { VAL };                         \
+            auto got = nlohmann::json::parse(encoded_);                   \
+            ASSERT_EQ(got, expected);                                     \
+        });                                                               \
+    }                                                                     \
+                                                                          \
+    TEST_F(FIXTURE, PublicKey_ ## NAME ## _to_json) {                     \
+        writeTest(#NAME ".json", [&]() -> json {                          \
+            return nlohmann::json(fetchers::PublicKey { VAL });           \
+        }, [](const auto & file) {                                        \
+            return json::parse(readFile(file));                           \
+        }, [](const auto & file, const auto & got) {                      \
+            return writeFile(file, got.dump(2) + "\n");                   \
+        });                                                               \
+    }
+
+TEST_JSON(PublicKeyTest, simple, (fetchers::PublicKey { .type = "ssh-rsa", .key = "ABCDE" }))
+
+TEST_JSON(PublicKeyTest, defaultType, fetchers::PublicKey { .key = "ABCDE" })
+
+#undef TEST_JSON
 }