From 5169f5f4d9743fa10a8578625d2c290141949d54 Mon Sep 17 00:00:00 2001 From: John Ericson Date: Mon, 12 Feb 2024 12:01:54 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Robert Hensing --- doc/manual/src/protocols/store-path.md | 2 +- src/libstore/store-api.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/manual/src/protocols/store-path.md b/doc/manual/src/protocols/store-path.md index 2fc4bf7af..1f619e6a2 100644 --- a/doc/manual/src/protocols/store-path.md +++ b/doc/manual/src/protocols/store-path.md @@ -111,7 +111,7 @@ where [Nix Archive (NAR)]: @docroot@/glossary.md#gloss-NAR [sha-256]: https://en.m.wikipedia.org/wiki/SHA-256 -## Historical Note +### Historical Note The `type` = `"source:" ...` and `type` = `"output:out"` grammars technically overlap in purpose, in that both can represent data hashed by its SHA-256 NAR serialization. diff --git a/src/libstore/store-api.cc b/src/libstore/store-api.cc index 1fb6cdce7..4238cbbf5 100644 --- a/src/libstore/store-api.cc +++ b/src/libstore/store-api.cc @@ -69,7 +69,7 @@ StorePath Store::followLinksToStorePath(std::string_view path) const The exact specification of store paths is in `protocols/store-path.md` in the Nix manual. These few functions implement that specification. -If changes do these functions go behind mere implementation changes but +If changes to these functions go beyond mere implementation changes i.e. also update the user-visible behavior, please update the specification to match. */