Split tests some more

Good for parallelism and easier reading.

tests/local.mk

@@ -138,7 +138,9 @@ nix_tests = \
   toString-path.sh
 
 overlay-local-store-tests := \
-  $(d)/overlay-local-store/outer.sh \
+  $(d)/overlay-local-store/check-post-init.sh \
+  $(d)/overlay-local-store/redundant-add.sh \
+  $(d)/overlay-local-store/build.sh \
   $(d)/overlay-local-store/bad-uris.sh
 
 install-tests-groups += overlay-local-store

tests/overlay-local-store/build-inner.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+set -eu -o pipefail
+
+set -x
+
+source common.sh
+
+storeDirs
+
+initLowerStore
+
+mountOverlayfs
+
+### Do a build in overlay store
+
+path=$(nix-build ../hermetic.nix --arg busybox $busybox --arg seed 2 --store "$storeB" --no-out-link)
+
+# Checking for path in lower layer (should fail)
+expect 1 stat $(toRealPath "$storeA/nix/store" "$path")
+
+# Checking for path in upper layer
+stat $(toRealPath "$storeBTop" "$path")
+
+# Verifying path in overlay store
+nix-store --verify-path --store "$storeB" "$path"

tests/overlay-local-store/build.sh

@@ -2,4 +2,4 @@ source common.sh
 
 requireEnvironment
 setupConfig
-exec unshare --mount --map-root-user ./inner.sh
+execUnshare ./build-inner.sh

tests/overlay-local-store/check-post-init-inner.sh

@@ -65,29 +65,3 @@ hashPart=$(echo $path | sed "s^$NIX_STORE_DIR/^^" | sed 's/-.*//')
 
 # merged store can find from hash part
 [[ $(nix store --store $storeB path-from-hash-part $hashPart) == $path ]]
-
-### Do a redundant add
-
-# upper layer should not have it
-expect 1 stat $(toRealPath "$storeBTop/nix/store" "$path")
-
-path=$(nix-store --store "$storeB" --add ../dummy)
-
-# lower store should have it from before
-stat $(toRealPath "$storeA/nix/store" "$path")
-
-# upper layer should still not have it (no redundant copy)
-expect 1 stat $(toRealPath "$storeB/nix/store" "$path")
-
-### Do a build in overlay store
-
-path=$(nix-build ../hermetic.nix --arg busybox $busybox --arg seed 2 --store "$storeB" --no-out-link)
-
-# Checking for path in lower layer (should fail)
-expect 1 stat $(toRealPath "$storeA/nix/store" "$path")
-
-# Checking for path in upper layer
-stat $(toRealPath "$storeBTop" "$path")
-
-# Verifying path in overlay store
-nix-store --verify-path --store "$storeB" "$path"

tests/overlay-local-store/check-post-init.sh

@@ -0,0 +1,5 @@
+source common.sh
+
+requireEnvironment
+setupConfig
+execUnshare ./check-post-init-inner.sh

tests/overlay-local-store/common.sh

@@ -1,23 +1,23 @@
 source ../common.sh
 
 requireEnvironment () {
-    requireSandboxSupport
+  requireSandboxSupport
-    [[ $busybox =~ busybox ]] || skipTest "no busybox"
+  [[ $busybox =~ busybox ]] || skipTest "no busybox"
-    if [[ $(uname) != Linux ]]; then skipTest "Need Linux for overlayfs"; fi
+  if [[ $(uname) != Linux ]]; then skipTest "Need Linux for overlayfs"; fi
-    needLocalStore "The test uses --store always so we would just be bypassing the daemon"
+  needLocalStore "The test uses --store always so we would just be bypassing the daemon"
 }
 
 setupConfig () {
-    echo "drop-supplementary-groups = false" >> "$NIX_CONF_DIR"/nix.conf
+  echo "drop-supplementary-groups = false" >> "$NIX_CONF_DIR"/nix.conf
-    echo "build-users-group = " >> "$NIX_CONF_DIR"/nix.conf
+  echo "build-users-group = " >> "$NIX_CONF_DIR"/nix.conf
 }
 
 storeDirs () {
-    storeA="$TEST_ROOT/store-a"
+  storeA="$TEST_ROOT/store-a"
-    storeBTop="$TEST_ROOT/store-b"
+  storeBTop="$TEST_ROOT/store-b"
-    storeB="local-overlay?root=$TEST_ROOT/merged-store&lower-store=$storeA&upper-layer=$storeBTop"
+  storeB="local-overlay?root=$TEST_ROOT/merged-store&lower-store=$storeA&upper-layer=$storeBTop"
-    # Creating testing directories
+  # Creating testing directories
-    mkdir -p "$TEST_ROOT"/{store-a/nix/store,store-b,merged-store/nix/store,workdir}
+  mkdir -p "$TEST_ROOT"/{store-a/nix/store,store-b,merged-store/nix/store,workdir}
 }
 
 # Mounting Overlay Store
@@ -50,3 +50,7 @@ initLowerStore () {
   drvPath=$(nix-instantiate --store $storeA ../hermetic.nix --arg busybox "$busybox" --arg seed 1)
   path=$(nix-store --store "$storeA" --realise $drvPath)
 }
+
+execUnshare () {
+  exec unshare --mount --map-root-user "$@"
+}

tests/overlay-local-store/redundant-add-inner.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+set -eu -o pipefail
+
+set -x
+
+source common.sh
+
+storeDirs
+
+initLowerStore
+
+mountOverlayfs
+
+### Do a redundant add
+
+# upper layer should not have it
+expect 1 stat $(toRealPath "$storeBTop/nix/store" "$path")
+
+path=$(nix-store --store "$storeB" --add ../dummy)
+
+# lower store should have it from before
+stat $(toRealPath "$storeA/nix/store" "$path")
+
+# upper layer should still not have it (no redundant copy)
+expect 1 stat $(toRealPath "$storeB/nix/store" "$path")

tests/overlay-local-store/redundant-add.sh

@@ -0,0 +1,5 @@
+source common.sh
+
+requireEnvironment
+setupConfig
+execUnshare ./redundant-add-inner.sh