max/nix-super
1
0
Fork 0
mirror of https://github.com/privatevoid-net/nix-super.git synced 2025-02-16 15:17:18 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

file-descriptor.hh: Avoid some Cism for better C++isms

Browse source 
- `reinterpret_cast` not C-style cast
- `using` not `typedef`
This commit is contained in:
John Ericson 2024-04-17 19:55:40 -04:00
parent c16fc2c1bd
commit 9c815db366
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/libutil/file-descriptor.hh
View file

@ -17,13 +17,13 @@ struct Source;
/** /**
* Operating System capability * Operating System capability
*/ */
typedef using Descriptor =
#if _WIN32 #if _WIN32
HANDLE HANDLE
#else #else
int int
#endif #endif
Descriptor; ;
const Descriptor INVALID_DESCRIPTOR = const Descriptor INVALID_DESCRIPTOR =
#if _WIN32 #if _WIN32
@ -41,7 +41,7 @@ const Descriptor INVALID_DESCRIPTOR =
static inline Descriptor toDescriptor(int fd) static inline Descriptor toDescriptor(int fd)
{ {
#ifdef _WIN32 #ifdef _WIN32
return (HANDLE) _get_osfhandle(fd); return reinterpret_cast<HANDLE>(_get_osfhandle(fd));
#else #else
return fd; return fd;
#endif #endif
@ -56,7 +56,7 @@ static inline Descriptor toDescriptor(int fd)
static inline int fromDescriptorReadOnly(Descriptor fd) static inline int fromDescriptorReadOnly(Descriptor fd)
{ {
#ifdef _WIN32 #ifdef _WIN32
return _open_osfhandle((intptr_t) fd, _O_RDONLY); return _open_osfhandle(reinterpret_cast<intptr_t>(fd), _O_RDONLY);
#else #else
return fd; return fd;
#endif #endif