max/nix-super
1
0
Fork 0
mirror of https://github.com/privatevoid-net/nix-super.git synced 2025-02-07 18:57:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review

Browse source 
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
This commit is contained in:
John Ericson 2023-12-11 13:18:34 -05:00 • committed by GitHub
parent 245af3ea02
commit c30b5d8a0b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/libstore/local-overlay-store.hh
View file

@ -24,7 +24,7 @@ struct LocalOverlayStoreConfig : virtual LocalStoreConfig
const PathSetting upperLayer{(StoreConfig*) this, "", "upper-layer", const PathSetting upperLayer{(StoreConfig*) this, "", "upper-layer",
R"( R"(
Must be used as OverlayFS upper layer for this store's store dir. Directory containing the OverlayFS upper layer for this store's store dir.
)"}; )"};
Setting<bool> checkMount{(StoreConfig*) this, true, "check-mount", Setting<bool> checkMount{(StoreConfig*) this, true, "check-mount",
@ -60,6 +60,7 @@ struct LocalOverlayStoreConfig : virtual LocalStoreConfig
std::string doc() override; std::string doc() override;
protected:
/** /**
* Given a store path, get its location (if it is exists) in the * Given a store path, get its location (if it is exists) in the
* upper layer of the overlayfs. * upper layer of the overlayfs.
@ -167,7 +168,7 @@ private:
* Deduplicate by removing store objects from the upper layer that * Deduplicate by removing store objects from the upper layer that
* are now in the lower layer. * are now in the lower layer.
* *
* This implementation will not cause duplications, but addition of * Operations on a layered store will not cause duplications, but addition of
* new store objects to the lower layer can instill induce them * new store objects to the lower layer can instill induce them
* (there is no way to prevent that). This cleans up those * (there is no way to prevent that). This cleans up those
* duplications. * duplications.