From ef40448b1cb33165af5522f72d5d352d66035671 Mon Sep 17 00:00:00 2001 From: Ben Radford Date: Mon, 19 Jun 2023 13:47:21 +0100 Subject: [PATCH] Remove redundant description on experimental flag. --- src/libstore/local-store.hh | 1 + src/libutil/experimental-features.cc | 8 -------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/libstore/local-store.hh b/src/libstore/local-store.hh index bd4794eb8..1af64c77b 100644 --- a/src/libstore/local-store.hh +++ b/src/libstore/local-store.hh @@ -59,6 +59,7 @@ struct LocalStoreConfig : virtual LocalFSStoreConfig **Warning** Do not use this unless the filesystem is read-only. Using it when the filesystem is writable can cause incorrect query results or corruption errors if the database is changed by another process. + While the filesystem the database resides on might appear to be read-only, consider whether another user or system might have write access to it. )"}; const std::string name() override { return "Local Store"; } diff --git a/src/libutil/experimental-features.cc b/src/libutil/experimental-features.cc index 7c2b29a07..3a04083ed 100644 --- a/src/libutil/experimental-features.cc +++ b/src/libutil/experimental-features.cc @@ -226,14 +226,6 @@ constexpr std::array xpFeatureDetails = {{ .name = "read-only-local-store", .description = R"( Allow the use of the `read-only` parameter in local store URIs. - - Set this parameter to `true` to allow stores with databases on read-only filesystems to be opened for querying; ordinarily Nix will refuse to do this. - - This is because SQLite requires write access to the database file to perform the file locking operations necessary for safe concurrent access. - When `read-only` is set to `true`, the database will be opened in immutable mode. - - Under this mode, SQLite will not do any locking at all, so you should be certain that the database will not be changed. - While the filesystem the database resides on might be read-only to this process, consider whether another user, process, or system, might have write access to it. )", }, }};