Ben Burdette
6faa56ea1f
remove extra argument
2022-05-15 12:05:34 -06:00
Eli Kogan-Wang
be2b19041e
Integrate review changes
2022-05-13 22:02:28 +02:00
Tom Bereknyei
8150b93968
fix: alignment during flake show of legacyPackages
...
Fixes:
https://github.com/NixOS/nix/issues/6240
https://github.com/NixOS/nix/issues/6045
2022-05-13 11:12:11 -04:00
Eelco Dolstra
de35e2d3b4
Fix resolving indirect flakerefs
2022-05-13 14:41:42 +02:00
Eelco Dolstra
bf89cd95a4
Merge pull request #6525 from J-Swift/feature/bash-prefix
...
Add `bash-prompt-prefix` option
2022-05-13 14:06:07 +02:00
Eelco Dolstra
a0ed002ba9
Fix build
2022-05-12 22:49:54 +02:00
Ben Burdette
2acdb90438
remove debug code
2022-05-12 14:20:45 -06:00
Ben Burdette
2d0d1ec99d
remove debug code
2022-05-12 14:15:35 -06:00
Ben Burdette
4f48095c66
Merge branch 'debugThrow' into debug-exploratory-PR
2022-05-12 14:11:35 -06:00
Ben Burdette
1ea13084c9
template-ize debugThrow
2022-05-12 13:59:58 -06:00
Eelco Dolstra
212e28d945
Fix test
2022-05-12 20:47:27 +02:00
Eelco Dolstra
9411299875
Fix GC bug in ExprPath
2022-05-12 20:37:18 +02:00
Eelco Dolstra
9e05daaa9e
Fix flake subdir handling
2022-05-12 19:31:07 +02:00
Eelco Dolstra
1ee5dd6d96
Fix relative path handling in the parser
2022-05-12 18:38:30 +02:00
Eelco Dolstra
cd893a22f5
Make the file cache keyed on SourcePath
2022-05-12 16:48:22 +02:00
Eelco Dolstra
bc57bd2202
Temporarily disable the eval cache
2022-05-12 14:52:34 +02:00
Eelco Dolstra
84c273c503
Fix path concatenation
2022-05-12 14:48:25 +02:00
Eelco Dolstra
b6cf6e5553
ZipInputAccessor: Fix symlink handling
2022-05-12 12:06:50 +02:00
Théophane Hufschmitt
65a913d29b
Don’t recommend writing unit tests
...
As asked in <https://github.com/NixOS/nix/pull/6517#discussion_r869416905 >
2022-05-12 12:02:31 +02:00
Eelco Dolstra
65c957f0c1
Merge remote-tracking branch 'origin/master' into lazy-trees
2022-05-12 11:31:09 +02:00
Eelco Dolstra
d354fc30b9
Merge branch 'fix-unrecognized-archive-format' of https://github.com/NobbZ/nix
2022-05-12 11:24:51 +02:00
Norbert Melzer
831e2743ea
fix GitHub URL template
2022-05-12 00:56:39 +02:00
Théophane Hufschmitt
b944b588fa
Merge pull request #6523 from ncfavier/stop-logger-legacy
...
Stop the logger properly in legacy commands
2022-05-11 16:53:57 +02:00
Eelco Dolstra
feac6d8651
Fix addPath()
2022-05-11 16:29:17 +02:00
Eelco Dolstra
8b5f37ea92
Fix support for coerceToPath() on attrsets with an outPath attribute
2022-05-11 15:48:21 +02:00
Eelco Dolstra
eb966921ca
Fix read-only copyPathToStore()
2022-05-11 14:22:18 +02:00
Eelco Dolstra
95e4376434
Fix eval tests
2022-05-11 13:45:57 +02:00
Eelco Dolstra
087584ef4d
Merge remote-tracking branch 'origin/master' into lazy-trees
2022-05-11 13:34:49 +02:00
Naïm Favier
1461e6cdda
Stop the logger properly in legacy commands
...
Ensures the logger is stopped on exit in legacy commands. Without this,
when using `nix-build --log-format bar` and stopping nix with CTRL+C,
the bar is not cleared from the screen.
2022-05-11 12:58:45 +02:00
Eli Kogan-Wang
aefc6c4f41
Add priority for nix profile install
2022-05-11 12:16:35 +02:00
Eelco Dolstra
54457382f9
Fix static build
...
https://hydra.nixos.org/build/176211267
2022-05-11 11:36:56 +02:00
Jimmy Reichley
584475acf9
Add documentation for bash-prompt-prefix
2022-05-10 16:55:25 -04:00
Jimmy Reichley
2998527b18
Allow setting bash-prompt-prefix nix develop configuration
2022-05-10 16:53:22 -04:00
Eelco Dolstra
eb957ad6d8
Merge pull request #6497 from danielfullmer/ghe-fetcher-url
...
Use correct URL for GitHub Enterprise
2022-05-10 19:23:22 +02:00
Eelco Dolstra
73b9b008f0
Merge pull request #6518 from edolstra/fix-nix-develop
...
nix develop: Find bin/bash in the bashInteractive outputs
2022-05-10 17:10:13 +02:00
Eelco Dolstra
a9cbc2857f
nix develop: Find bin/bash in the bashInteractive outputs
2022-05-10 16:43:41 +02:00
Eelco Dolstra
b4c6adfd35
Fix findFile(), coerceToPath()
2022-05-10 16:12:48 +02:00
Théophane Hufschmitt
7c75f1d52b
Expand the testing section of the hacking docs
...
- Make it clear what the different kind of tests are, where they live
and how they can be ran
- Ask people to primarily write unit tests
2022-05-10 13:35:23 +02:00
Eelco Dolstra
7062ebf5be
Merge pull request #6510 from NixOS/dependabot/github_actions/docker/login-action-2
...
Bump docker/login-action from 1 to 2
2022-05-10 13:06:28 +02:00
dependabot[bot]
c060e93b3c
Bump docker/login-action from 1 to 2
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1 to 2.
- [Release notes](https://github.com/docker/login-action/releases )
- [Commits](https://github.com/docker/login-action/compare/v1...v2 )
---
updated-dependencies:
- dependency-name: docker/login-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-05-09 22:01:15 +00:00
Ben Burdette
7cd7c7c91a
Merge branch 'master' into debug-exploratory-PR
2022-05-09 09:30:44 -06:00
Eelco Dolstra
e7f8aa8bdd
Fix copyPathToStore()
2022-05-09 15:29:42 +02:00
Eelco Dolstra
e89d3e0edf
Fix resolveExprPath()
2022-05-09 14:28:47 +02:00
Eelco Dolstra
53869fbd42
Add operator for concatenating strings and string_views
2022-05-09 14:28:27 +02:00
Eelco Dolstra
0d3392bef1
Fix build
2022-05-09 12:55:25 +02:00
Eelco Dolstra
30ca717558
Merge remote-tracking branch 'origin/master' into lazy-trees
2022-05-09 11:26:39 +02:00
Théophane Hufschmitt
3ec979fa90
Merge pull request #6505 from jtojnar/patch-3
...
libexpr: Fix manual link in error message
2022-05-09 11:09:32 +02:00
Jan Tojnar
59d9551c25
libexpr: Fix manual link in error message
...
It was changed to the old manual in 8895fa70a4
2022-05-08 18:59:00 +02:00
Daniel Fullmer
7a3d5b2ff0
Use correct URL for GitHub Enterprise
...
For GitHub Enterprise, the API is accessed through a slightly different
URL. See [1], where it says:
> Use http(s)://[hostname]/api/v3 to access the API for GitHub
> Enterprise Server.
Also tested working on a GHE instance.
[1] https://docs.github.com/en/enterprise-server@3.3/rest/guides/getting-started-with-the-rest-api
2022-05-06 13:13:11 -07:00
Andreas Rammhold
059ae7f6c4
Add unit tests for libexpr ( #5377 )
...
* libexpr: fix builtins.split example
The example was previously indicating that multiple whitespaces would be
collapsed into a single captured whitespace. That isn't true and was
likely a mistake when being documented initially.
* Fix segfault on unitilized list when printing value
Since lists are just chunks of memory the individual elements in the
list might be unitilized when a programming error happens within Nix.
In this case the values are null-initialized (at least with Boehm GC)
and we can avoid a nullptr deref when printing them.
I ran into this issue while ensuring that new expression tests would
show the actual value on an assertion failure.
This is unlikely to cause any runtime performance regressions as
printing values is not really in the hot path (unless the repl is the
primary use case).
* Add operator<< for ValueTypes
* Add libexpr tests
This introduces tests for libexpr that evalulate various trivial Nix
language expressions and primop invocations that should be good smoke
tests wheter or not the implementation is behaving as expected.
2022-05-06 18:05:27 +02:00
