3 commits

Author	SHA1	Message	Date
Eelco Dolstra	c1d5cf6f34	Factor out commonality between WorkerProto::Basic{Client,Server}Connection ... This also renames clientVersion and daemonVersion to the more correct protoVersion (since it's the version agreed to by both sides).	2024-07-18 16:10:48 +02:00
Eelco Dolstra	87f8ff23fe	BasicClientConnection::handshake(): Don't send our version twice ... This was accidentally introduced in f71b4da0b3. We didn't notice this because the version got interpreted by the daemon as the obsolete "CPU affinity will follow" field, and being non-zero, it would then read another integer for the ignored CPU affinity.	2024-07-17 16:51:53 +02:00
John Ericson	f71b4da0b3	Factor our connection code for worker proto like serve proto ... This increases test coverage, and gets the worker protocol ready to be used by Hydra. Why don't we just try to use the store interface in Hydra? Well, the problem is that the store interface works on connection pools, with each opreation getting potentially a different connection, but the way temp roots work requires that we keep one logical "transaction" (temp root session) using the same connection. The longer-term solution probably is making connections themselves implement the store interface, but that is something that builds on this, so I feel OK that this is not churn in the wrong direction. Fixes #9584	2024-05-27 00:43:46 -04:00