John Ericson
7ff43435f9
Unit test some worker protocol serializers
...
Continue with the characterization testing idioms begun in
c70484454f
, but this time for unit tests.
Co-authored-by: Andreas Rammhold <andreas@rammhold.de>
2023-09-05 10:48:02 -04:00
Valentin Gagarin
f878b422b0
Merge pull request #8422 from fricklerhandwerk/remove-checklist
...
move PR checklist to contributing guide
2023-09-05 15:05:18 +02:00
Valentin Gagarin
3a9c1dc8a3
add checklist to contribution guide
2023-09-05 14:08:40 +02:00
Valentin Gagarin
4f2b949ba8
reorder list items
2023-09-05 14:08:40 +02:00
Valentin Gagarin
cc388fbc3a
remove maintainers checklist in PR template
...
maintainers are not really using it, and it produces a lot of noise when opening PRs.
2023-09-05 14:08:40 +02:00
Valentin Gagarin
f34484d18a
Merge pull request #7592 from fricklerhandwerk/nix-store-realise
...
reword description of how realisation works
2023-09-05 11:55:01 +02:00
dependabot[bot]
87508b1065
Bump cachix/install-nix-action from 22 to 23
...
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action ) from 22 to 23.
- [Release notes](https://github.com/cachix/install-nix-action/releases )
- [Commits](https://github.com/cachix/install-nix-action/compare/v22...v23 )
---
updated-dependencies:
- dependency-name: cachix/install-nix-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-09-04 22:52:40 +00:00
dependabot[bot]
73f6407eea
Bump actions/checkout from 3 to 4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-09-04 22:52:37 +00:00
Robert Hensing
477bc617bb
traces: Add _NIX_DEVELOPER_SHOW_UNKNOWN_LOCATIONS
2023-09-03 14:08:03 +02:00
Robert Hensing
f1aeeea32b
traces: DRY printPosMaybe
2023-09-03 14:00:55 +02:00
Robert Hensing
4c50f5d130
traces: Do not print unknown location
...
Solves 1/3 of the infinite recursion at unknown location meme.
See #8879 for ensuring we always have a trace (for stack overflows)
We might want to re-add this for finding missing location info
*while hacking on that problem only*.
2023-09-03 13:44:32 +02:00
Walter Franzini
3ae1489847
nix flakes metadata: Show lastModified timestamp for each input
...
Before this commit, the output of `nix flake metadata` in nix repo
looked like this:
...
Last modified: 2023-07-09 16:00:16
Inputs:
├───flake-compat: github:edolstra/flake-compat/35bb57c0c8d8b62bbfd284272c928ceb64ddbde9
├───lowdown-src: github:kristapsdz/lowdown/d2c2b44ff6c27b936ec27358a2653caaef8f73b8
├───nixpkgs: github:NixOS/nixpkgs/04a75b2eecc0acf6239acf9dd04485ff8d14f425
└───nixpkgs-regression: github:NixOS/nixpkgs/215d4d0fd80ca5163643b03a33fde804a29cc1e2
This commit changes that to:
...
Last modified: 2023-07-09 16:00:16
Inputs:
├───flake-compat: github:edolstra/flake-compat/35bb57c0c8d8b62bbfd284272c928ceb64ddbde9 (2023-01-17 11:47:33)
├───lowdown-src: github:kristapsdz/lowdown/d2c2b44ff6c27b936ec27358a2653caaef8f73b8 (2021-10-06 10:00:07)
├───nixpkgs: github:NixOS/nixpkgs/04a75b2eecc0acf6239acf9dd04485ff8d14f425 (2022-12-08 01:04:00)
└───nixpkgs-regression: github:NixOS/nixpkgs/215d4d0fd80ca5163643b03a33fde804a29cc1e2 (2022-01-24 19:20:45)
2023-09-03 12:35:29 +02:00
Eelco Dolstra
4a8c9bb9aa
Merge pull request #8898 from edolstra/fix-catch-polymorphic-by-value
...
Fix warning 'catching polymorphic type by value'
2023-09-01 15:33:56 +02:00
Eelco Dolstra
5c95b32c46
Fix warning 'catching polymorphic type by value'
2023-09-01 14:49:49 +02:00
Eelco Dolstra
3420b60b39
Merge pull request #8863 from symphorien/valid_deriver_2
...
add nix-store --query --valid-derivers command
2023-09-01 14:16:06 +02:00
Vladimír Čunát
539cc5e5f0
flake: update nixpkgs: 22.11 -> 23.05
...
The lowdown input can't be updated; `nix build` would fail to find it.
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-09-01 14:07:25 +02:00
Eelco Dolstra
919781cacc
Merge branch 'master' into valid_deriver_2
2023-09-01 13:35:05 +02:00
Eelco Dolstra
b88784278f
Merge pull request #8869 from hercules-ci/fix-issue-8838-pathExists-isDir
...
Fix #8838 , pathExists: isDir when ends with `/ `
2023-09-01 13:15:54 +02:00
Valentin Gagarin
1ac181759d
revert some random change
2023-08-31 21:27:13 +02:00
Valentin Gagarin
d38a539437
make description open-ended, add TODO
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-08-31 21:27:11 +02:00
Valentin Gagarin
894cbe43bc
don't invent terms yet
2023-08-31 21:26:46 +02:00
Valentin Gagarin
b951e862d0
more meaningful tagline
2023-08-31 21:26:46 +02:00
Valentin Gagarin
cf4e14d58d
accommodate "do nothing" branch
2023-08-31 21:26:46 +02:00
Valentin Gagarin
d460dbdd30
be more precise about substituting store derivations
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-08-31 21:26:46 +02:00
Valentin Gagarin
6b3320ab05
mention remote builders
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-08-31 21:26:44 +02:00
Valentin Gagarin
0cd8f36644
add anchor to builder
2023-08-31 21:26:15 +02:00
Valentin Gagarin
d50f116421
add reference link
2023-08-31 21:25:39 +02:00
Valentin Gagarin
b7e9e29605
remove abstract description
2023-08-31 21:25:39 +02:00
Valentin Gagarin
a57e0e8c5c
reword introductory sentence
2023-08-31 21:25:39 +02:00
Valentin Gagarin
315a11bcc9
remove superfluous word
2023-08-31 21:25:39 +02:00
Valentin Gagarin
1bc9257d7c
reword description of how realisation works
2023-08-31 21:25:39 +02:00
Robert Hensing
be3362e747
Fix nix-copy test
2023-08-30 19:35:02 -04:00
Robert Hensing
3384f70a3d
nixpkgsLibTests: Only test our Nix
...
Interface has changed upstream.
It *should* be fine to test 23.05's other Nix versions as those
*should* succeed, but that's not the case and it's obfuscating
our terrible CI setup's log.
2023-08-30 19:34:35 -04:00
Cole Helbling
46478b44ff
docs/testing: point out the existence of GTEST_FILTER
( #8883 )
2023-08-29 22:13:35 +00:00
Eelco Dolstra
5b5f56a9d4
Merge pull request #8859 from edolstra/tarball-last-modified
...
Tarball trees: Propagate lastModified
2023-08-29 17:02:06 +02:00
Eelco Dolstra
56763ff918
Document that redirected tarball flakerefs can specify lastModified
2023-08-29 16:08:29 +02:00
Silvan Mosberger
151120a1ae
Document nix-prefetch-url defaults ( #8878 )
2023-08-28 22:14:01 +02:00
Valentin Gagarin
880fef9cdf
do not change existing release notes
2023-08-28 20:52:30 +02:00
Bryan Honof
736b9cede7
Port the flags of nix-daemon to nix daemon ( #8788 )
...
The new `nix daemon` command didn't accept the same flags that `nix-daemon` did.
* docs(daemon): clarify the daemon trust override flags
* fix: change declaration order
* docs: add examples of nix daemon usage
* Apply suggestions from code review
---------
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: John Ericson <git@JohnEricson.me>
Co-authored-by: tomberek <tomberek@users.noreply.github.com>
2023-08-28 13:43:34 +00:00
Tom Bereknyei
696eb79b15
test: test behavior of .-prefixed attrPaths
2023-08-27 04:42:52 -04:00
Robert Hensing
1e08e12d81
pathExists: isDir when endswith /
...
Fixes https://github.com/NixOS/nix/issues/8838
2023-08-25 17:18:37 +02:00
Robert Hensing
d2e6cfa075
tests/lang/eval-okay-pathexists: Add cases
2023-08-25 17:17:33 +02:00
John Ericson
50f40ac4c0
Merge pull request #8829 from obsidiansystems/build-dynamic-derivations
...
Adapt scheduler to work with dynamic derivations
2023-08-25 11:13:15 -04:00
tomberek
b563ef38cc
Merge pull request #8819 from VertexA115/fix/deep-follow-paths
...
Fix follow path checking at depths greater than 2
2023-08-25 10:33:05 -04:00
John Ericson
dd9f816b29
Merge pull request #8661 from hercules-ci/test-reformat-error-message
...
tests: Reformat exit code error message
2023-08-25 10:17:15 -04:00
John Ericson
cbd89568ca
Merge pull request #8814 from hercules-ci/exception-self-check
...
initLibUtil: Add exception handling self-check
2023-08-25 10:15:54 -04:00
John Ericson
5e3986f59c
Adapt scheduler to work with dynamic derivations
...
To avoid dealing with an optional `drvPath` (because we might not know
it yet) everywhere, make an `CreateDerivationAndRealiseGoal`. This goal
just builds/substitutes the derivation file, and then kicks of a build
for that obtained derivation; in other words it does the chaining of
goals when the drv file is missing (as can already be the case) or
computed (new case).
This also means the `getDerivation` state can be removed from
`DerivationGoal`, which makes the `BasicDerivation` / in memory case and
`Derivation` / drv file file case closer together.
The map type is factored out for clarity, and because we will soon hvae
a second use for it (`Derivation` itself).
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-08-25 10:01:25 -04:00
John Ericson
692074f714
Use Worker::makeDerivationGoal
less
...
We're about to split up `DerivationGoal` a bit. At that point
`makeDerivationGoal` will mean something more specific than it does
today. (Perhaps a future rename will make this clearer.)
On the other hand, the more public `Worker::makeGoal` function will
continue to work exactly as before. So by moving some call sites to use
that instead, we preemptively avoid issues in the next step.
2023-08-25 09:55:07 -04:00
John Ericson
1c4caef14b
Throw MissingRealisation
not plain Error
in both resolveDerivedPath
...
Now we are consistent with the other `resolveDerivedPath`, and other
such functions.
2023-08-25 09:55:07 -04:00
John Ericson
2f5d3da806
Introduce OutputName
and OutputNameView
type aliases
...
Hopefully they make the code easier to understand!
2023-08-25 09:55:07 -04:00