Eelco Dolstra
0a80db5112
Merge pull request #8541 from NixOS/contributing-good-first-issues
...
CONTRIBUTING.md: add link to "good first issues"
2023-06-19 12:46:42 +02:00
Valentin Gagarin
b6e74ea5a8
maintainers: add note on marking PRs as draft
...
as discussed with maintainers team
2023-06-19 10:55:34 +02:00
Valentin Gagarin
966e5dc991
CONTRIBUTING.md: add link to "good first issues"
2023-06-19 10:39:19 +02:00
Eelco Dolstra
8f6255b86a
Merge pull request #8524 from amjoseph-nixpkgs/pr/doc/linkify-allowed-uris
...
src/libexpr/eval.hh: add link for allowed-uris option
2023-06-19 06:59:07 +02:00
John Ericson
c404623a1d
Clean up a few things related to profiles ( #8526 )
...
- Greatly expand API docs
- Clean up code in misc ways
- Instead of a complicated single loop on generations, do different
operations in successive subsequent steps.
- Avoid `ref` in one place where `&` is fine
- Just return path instead of mutating an argument in `makeName`
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-06-19 04:04:59 +00:00
Valentin Gagarin
7bf17f8825
Add description for file system objects ( #8500 )
...
While this is not actually a notion in the implementation, it is
explicitly described in the thesis and quite important for understanding
how the store works.
Co-authored-by: John Ericson <git@JohnEricson.me>
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-06-18 23:45:08 -04:00
John Ericson
60d81b5163
Merge pull request #8472 from NixOS/nix-language-purpose
...
Refine wording on the purpose of the Nix language
2023-06-18 23:38:05 -04:00
Adam Joseph
6b06e97bde
src/libexpr/eval.hh: add link for allowed-uris option
...
This commit adds a link to the documentation for `--option
allowed-uris` where that option is mentioned while describing
`restrict-eval`.
2023-06-18 23:36:32 -04:00
John Ericson
d2ce2e89b1
Split OptionalPathSetting
from PathSetting
...
Rather than doing `allowEmpty` as boolean, have separate types and use
`std::optional`. This makes it harder to forget the possibility of an
empty path.
The `build-hook` setting was categorized as a `PathSetting`, but
actually it was split into arguments. No good! Now, it is
`Setting<Strings>` which actually reflects what it means and how it is
used.
Because of the subtyping, we now also have support for
`Setting<std::optional<String>>` in general. I imagine this can be used
to clean up many more settings also.
2023-06-18 23:31:18 -04:00
John Ericson
c8825e9d8c
Create nlohmann serializers for std::optional
and use
...
This is somewhat tricky.
2023-06-18 23:31:10 -04:00
Domen Kožar
3b0d8fd796
Merge pull request #8534 from ncfavier/ci
...
ci: bump install-nix-action, don't fail fast
2023-06-17 16:53:50 +01:00
Naïm Favier
b931d83550
ci: bump install-nix-action, don't fail fast
2023-06-17 15:05:10 +02:00
Christina Sørensen
741f7837f8
Fix wikipedia links ( #8533 )
2023-06-17 09:06:17 +00:00
Eelco Dolstra
e503eadafc
Merge pull request #8477 from edolstra/tarball-flake-redirects
...
Tarball flake improvements
2023-06-16 18:03:50 +02:00
Valentin Gagarin
f695a74751
Update src/libstore/globals.hh
2023-06-16 17:58:01 +02:00
Eelco Dolstra
b1ed9b4b0c
Apply suggestions from code review
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-06-16 16:48:37 +02:00
Eelco Dolstra
cab03fb779
Add docs
2023-06-16 15:58:42 +02:00
Valentin Gagarin
baef05e6fe
fix typo
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-06-16 14:37:08 +02:00
Valentin Gagarin
126eea48e3
do not refer to trusted-users
another time
2023-06-16 14:36:53 +02:00
Valentin Gagarin
1a8ca85d48
use "store URLs" consistently
2023-06-16 14:34:11 +02:00
Valentin Gagarin
4a33d5fe35
fix link text
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-06-16 14:33:31 +02:00
Eelco Dolstra
713836112c
Merge pull request #8517 from hercules-ci/fix-build-hook-error-for-lib-users
...
Fix build hook error for libstore library users
2023-06-16 13:20:50 +02:00
Eelco Dolstra
09320140b5
Merge pull request #8525 from tweag/fix-i686-build
...
Don't assume the type of string::size_type
2023-06-16 13:15:46 +02:00
Théophane Hufschmitt
b2247ef4f6
Don't assume the type of string::size_type
...
The code accidentally conflated `std::string::size_type` and `long unsigned int`.
This was fine on 64bits machines where they are apparently the same in
practice, but not on 32bits. Fix that by using `std::string::size_type`
everywhere.
2023-06-15 21:24:14 +02:00
Valentin Gagarin
2ceacce484
Update src/libstore/globals.hh
2023-06-15 15:57:54 +02:00
Ben Radford
abb3bb7133
Merge branch 'master' into read-only-local-store
2023-06-15 13:42:14 +01:00
Ben Radford
04d8f202a7
Merge branch 'read-only-local-store' into overlayfs-store
2023-06-15 13:37:57 +01:00
Ben Radford
f5d83a8029
One line per sentence in markdown docs.
2023-06-15 13:36:28 +01:00
Ben Radford
f2fe9822c1
Comment explaining what schema version 0 means.
2023-06-15 13:34:42 +01:00
Ben Radford
4642b60afe
Update src/libstore/local-store.hh
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-06-15 13:33:26 +01:00
Ben Radford
a7b1b92d81
Update src/libstore/local-store.hh
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-06-15 13:32:56 +01:00
Ben Radford
984b01924a
Update src/libstore/local-store.cc
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-06-15 13:32:35 +01:00
Ben Radford
78e2f931d0
Update src/libstore/local-store.cc
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-06-15 13:32:16 +01:00
Robert Hensing
d2696cdd1e
Fix build hook error for libstore library users
...
A library shouldn't require changes to the caller's argument handling,
especially if it doesn't have to, and indeed we don't have to.
This changes the lookup order to prioritize the hardcoded path to nix
if it exists. The static executable still finds itself through /proc
and the like.
2023-06-15 14:32:00 +02:00
Ben Radford
7cdaa0b8a6
Update tests/read-only-store.sh
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-06-15 13:25:15 +01:00
Ben Radford
264b644c53
More detail on why read-only mode disables locking.
2023-06-15 13:22:17 +01:00
Ben Radford
fad0dd4afb
Skip build-remote-trustless unless sandbox is supported.
2023-06-15 12:59:01 +01:00
John Ericson
e672d52f7c
Merge pull request #8512 from scarf005/install-show-uid
...
build: show UID and GID in welcome message
2023-06-15 13:49:44 +02:00
Ben Radford
7ed0ab2dab
Check _NIX_TEST_NO_SANDBOX when setting _canUseSandbox.
2023-06-15 12:48:08 +01:00
John Ericson
e1fa48f17c
Update src/nix/daemon.cc
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-06-15 07:41:37 -04:00
John Ericson
71e53c0c6a
Merge pull request #8522 from amjoseph-nixpkgs/pr/allowed-uris/typo
...
src/libexpr/eval.hh: fix typo
2023-06-15 13:20:42 +02:00
scarf
80451b762d
style: use plurals in uid ranges
...
Co-authored-by: John Ericson <git@JohnEricson.me>
2023-06-15 14:47:18 +09:00
Adam Joseph
098fbf6273
src/libexpr/eval.hh: fix typo
...
The option name is `allowed-uris`, not `allowed-uri`.
2023-06-14 21:47:58 -07:00
Valentin Gagarin
b7d47e1d22
fix wording
2023-06-15 04:58:07 +02:00
John Ericson
2e47e53953
Merge pull request #8521 from fricklerhandwerk/issue-templates
...
docs issue template: move checklist down
2023-06-15 03:47:31 +02:00
John Ericson
d11faa01b5
Merge pull request #8520 from fricklerhandwerk/rename-antiquote-tests
...
Rename files referring to antiquotation
2023-06-15 03:44:42 +02:00
Valentin Gagarin
c3c4076342
make domain-specificity more specific
...
also slightly reword the purpose statement to introduce (and explain)
derivations right away.
2023-06-15 03:08:07 +02:00
Valentin Gagarin
520491607e
docs issue template: move checklist down
...
it's annoying to write issues with the checklist in the way, and the
proposal is more important.
2023-06-15 02:31:49 +02:00
Valentin Gagarin
c453719d6e
rename files referring to antiquotation
...
since we renamed this to string interpolation, file names should be
fixed up as well
2023-06-15 02:29:31 +02:00
Valentin Gagarin
e09b40e0d0
reword documentation on trusted users and substituters
...
this is to make it slightly easier to scan over
2023-06-15 02:19:13 +02:00