13147 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Adam Joseph	36e1383b6b	local-derivation-goal.cc: save global errno to the stack before performing tests which might clobber it	2022-07-19 03:53:20 -07:00
Adam Joseph	a9e75eca00	error.hh: add additional constructor with explicit errno argument	2022-07-19 03:49:33 -07:00
Adam Joseph	99fcc91f67	as requested by @thufschmitt https://github.com/NixOS/nix/pull/6814#discussion_r924275777	2022-07-19 03:33:12 -07:00
Adam Joseph	5f51539f88	change warn() to notice()	2022-07-19 03:30:52 -07:00
Théophane Hufschmitt	fbd0a6c6e2	Merge pull request #6784 from tweag/completion-test ... Add some tests for the CLI completion	2022-07-18 20:32:14 +02:00
Eelco Dolstra	2584c151bd	Merge pull request #6812 from lovesegfault/rosetta-paths ... fix(libstore): allow Nix to access all Rosetta 2 paths on MacOS	2022-07-18 14:09:54 +02:00
Adam Joseph	c8c6203c2c	local-derivation-goal.cc: detect unprivileged_userns_clone failure mode ... The workaround for "Some distros patch Linux" mentioned in local-derivation-goal.cc will not help in the `--option sandbox-fallback false` case. To provide the user more helpful guidance on how to get the sandbox working, let's check to see if the `/proc` node created by the aforementioned patch is present and configured in a way that will cause us problems. If so, give the user a suggestion for how to troubleshoot the problem.	2022-07-17 01:27:22 -07:00
Adam Joseph	6fc56318bf	local-derivation-goal.cc: add comment re: CLONE_NEWUSER ... local-derivation-goal.cc contains a comment stating that "Some distros patch Linux to not allow unprivileged user namespaces." Let's give a pointer to a common version of this patch for those who want more details about this failure mode.	2022-07-17 01:23:32 -07:00
Adam Joseph	8d35f387dc	local-derivation-goal.cc: warn if failing and /proc/self/ns/user missing ... This commit causes nix to `warn()` if sandbox setup has failed and `/proc/self/ns/user` does not exist. This is usually a sign that the kernel was compiled without `CONFIG_USER_NS=y`, which is required for sandboxing.	2022-07-16 19:37:27 -07:00
Adam Joseph	90830b1074	local-derivation-goal.cc: warn if failing due to max_user_namespaces==0 ... This commit uses `warn()` to notify the user if sandbox setup fails with errno==EPERM and /proc/sys/user/max_user_namespaces is missing or zero, since that is at least part of the reason why sandbox setup failed. Note that `echo -n 0 > /proc/sys/user/max_user_namespaces` or equivalent at boot time has been the recommended mitigation for several Linux LPE vulnerabilities over the past few years. Many users have applied this mitigation and then forgotten that they have done so.	2022-07-16 19:30:53 -07:00
Adam Joseph	8ea3a911aa	local-derivation-goal.cc: improve error messages when sandboxing fails ... The failure modes for nix's sandboxing setup are pretty complicated. When nix is unable to set up the sandbox, let's provide more detail about what went wrong. Specifically: * Make sure the error message includes the word "sandbox" so the user knows that the failure was related to sandboxing. * If `--option sandbox-fallback false` was provided, and removing it would have allowed further attempts to make progress, let the user know.	2022-07-16 14:56:24 -07:00
Alex Wied	b88fb50e21	fix(libstore): allow Nix to access all Rosetta 2 paths on MacOS ... Fixes: #5884	2022-07-15 12:10:56 -07:00
John Ericson	12461e246b	Leverage existing docs for new store-path^outputs syntax	2022-07-15 14:04:22 +00:00
John Ericson	0e4ec98ae8	Fix typo in docs ... Thanks! Co-authored-by: Eelco Dolstra <edolstra@gmail.com>	2022-07-15 09:49:23 -04:00
John Ericson	279ecf7cde	Remove computed-derivations experimental feature ... We don't need it yet.	2022-07-15 13:42:17 +00:00
Eelco Dolstra	59764eb842	Merge pull request #6810 from jfly/jfly/do-not-assume-savedvars-exist ... nix develop: do not assume that saved vars are set	2022-07-15 13:59:25 +02:00
Eelco Dolstra	0621e99414	Merge pull request #6811 from edolstra/fix-auto-chroot ... Disable auto-chroot if $NIX_STATE_DIR is set	2022-07-15 13:11:08 +02:00
Eelco Dolstra	3bcd7a5474	Disable auto-chroot if $NIX_STATE_DIR is set ... Issue #6732.	2022-07-15 12:32:29 +02:00
Jeremy Fleischman	04386f7d69	nix develop: do not assume that saved vars are set ... This fixes https://github.com/NixOS/nix/issues/6809	2022-07-14 23:25:39 -07:00
Domen Kožar	de287964d5	Merge pull request #6807 from NixOS/curl-patch ... curl: patch for netrc regression in Nix	2022-07-14 19:30:14 -05:00
John Ericson	8735f55dec	Fix bug, test more, document more	2022-07-14 20:23:43 -04:00
John Ericson	f3262bc216	Combine InstallableStorePath with InstallableIndexedStorePath ... No behavior should be changed, the `isDerivation` logic is moved from the methods to the constructor.	2022-07-14 19:37:55 -04:00
Domen Kožar	99208bb8cc	curl: patch for netrc regression in Nix	2022-07-14 17:45:02 -05:00
John Ericson	6cafe308c9	Merge remote-tracking branch 'upstream/master' into indexed-store-path-outputs	2022-07-14 16:15:37 -04:00
Eelco Dolstra	ca4d5bee09	Merge pull request #6804 from edolstra/fix-auto-chroot ... Disable auto-chroot if $NIX_STORE_DIR is set	2022-07-14 18:24:08 +02:00
Eelco Dolstra	ff49c75502	Disable auto-chroot if $NIX_STORE_DIR is set ... Fixes #6732.	2022-07-14 17:47:09 +02:00
Eelco Dolstra	73ff9b863c	Merge pull request #6803 from edolstra/test-stack-trace ... On test failures, print a bash stack trace	2022-07-14 15:56:06 +02:00
Eelco Dolstra	2532fee157	On test failures, print a bash stack trace ... This makes it easier to identify what command failed. It looks like: follow-paths.sh: test failed at: main in follow-paths.sh:54	2022-07-14 15:07:19 +02:00
Eelco Dolstra	819615c7f4	Merge pull request #6802 from edolstra/split-flakes-tests ... Split flakes tests	2022-07-14 09:15:58 +02:00
Eelco Dolstra	b15c4fdbde	Split off 'nix flake check' tests	2022-07-13 21:01:16 +02:00
Eelco Dolstra	752158a8ef	Move flake-searching.sh and make it less dependent on git	2022-07-13 20:55:17 +02:00
Eelco Dolstra	6ba45f81a8	Move flake-local-settings.sh	2022-07-13 20:51:28 +02:00
Eelco Dolstra	7abcafcfea	Move the 'nix bundle' tests ... Note: these were previously not actually called.	2022-07-13 20:49:07 +02:00
Eelco Dolstra	d16f1070f4	Split off following paths tests	2022-07-13 20:46:22 +02:00
Eelco Dolstra	a094259d35	Split off 'nix flake init' tests	2022-07-13 20:37:40 +02:00
Eelco Dolstra	f011c269c9	Split off the circular flake import tests	2022-07-13 20:37:32 +02:00
Eelco Dolstra	c591efafd3	Split off the Mercurial flake tests	2022-07-13 15:06:57 +02:00
Eelco Dolstra	420957e149	Move flakes tests to a subdirectory	2022-07-13 15:06:54 +02:00
Eelco Dolstra	e1153069bd	Merge pull request #6797 from edolstra/overrides-check ... Simplify the check for overrides on non-existent inputs	2022-07-13 14:45:07 +02:00
Eelco Dolstra	19190c2346	tests/flakes.sh: Make sure flake7 is clean ... Cherry-picked from the lazy-trees branch, where we no longer write a lock file if any of the inputs is dirty.	2022-07-13 13:46:33 +02:00
Eelco Dolstra	12df8885cc	Simplify the check for overrides on non-existent inputs	2022-07-13 13:40:40 +02:00
Théophane Hufschmitt	438776cce7	Merge pull request #6794 from eltociear/patch-1 ... Fix typo in flake.cc	2022-07-13 10:55:25 +02:00
Théophane Hufschmitt	b052e7e71d	Add some more completion tests ... - Test another command than `build` - Test with two input flakes	2022-07-13 10:31:17 +02:00
Théophane Hufschmitt	d34a333e2e	Fix the “out of order” completion test ... `--override-input` id snarky because it takes two arguments, so it doesn't play well when completed in the middle of the CLI (since the argument just after gets interpreted as its second argument). So use `--update-input` instead	2022-07-13 10:25:28 +02:00
Ikko Ashimine	694a9dc282	Fix typo in flake.cc ... non-existant -> non-existent	2022-07-13 01:10:32 +09:00
Eelco Dolstra	a9fab18a91	Merge pull request #6791 from edolstra/fix-installer ... Fix --no-daemon installation	2022-07-12 17:00:38 +02:00
Théophane Hufschmitt	2dbd5ed0b4	Merge pull request #6663 from Ma27/follows-invalid-input ... flakes: throw an error if `follows`-declaration for an input is invalid	2022-07-12 16:44:22 +02:00
Eelco Dolstra	c9d406ba04	Fix --no-daemon installation ... It was accidentally triggering the auto-chroot code path because /nix/var/nix didn't exist. Fixes #6790.	2022-07-12 16:15:21 +02:00
Eelco Dolstra	f6a434c8a4	Fix debug message	2022-07-12 11:53:34 +02:00
Maximilian Bosch	1f771065f1	Move follows-check into its own function	2022-07-12 11:25:33 +02:00