nix-super

15654 commits 7 branches 0 tags 64 MiB

Author SHA1 Message Date

Author	SHA1	Message	Date
Robert Hensing	9b7b7a7561	Revert "Print the value in `error: cannot coerce` messages (#9553 )" This reverts commit `f0ac2a35d5`. The request from the sibling PR, which also applies here, was not addressed. https://github.com/NixOS/nix/pull/9554#issuecomment-1845095735	2023-12-09 02:13:32 +01:00
Rebecca Turner	f0ac2a35d5	Print the value in `error: cannot coerce` messages (#9553 ) * Print the value in `error: cannot coerce` messages This extends the `error: cannot coerce a TYPE to a string` message to print the value that could not be coerced. This helps with debugging by making it easier to track down where the value is being produced from, especially in errors with deep or unhelpful stack traces. Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>	2023-12-08 16:36:57 +00:00
John Ericson	68c81c7375	Put functional tests in `tests/functional` I think it is bad for these reasons when `tests/` contains a mix of functional and integration tests - Concepts is harder to understand, the documentation makes a good unit vs functional vs integration distinction, but when the integration tests are just two subdirs within `tests/` this is not clear. - Source filtering in the `flake.nix` is more complex. We need to filter out some of the dirs from `tests/`, rather than simply pick the dirs we want and take all of them. This is a good sign the structure of what we are trying to do is not matching the structure of the files. With this change we have a clean: ```shell-session $ git show 'HEAD:tests' tree HEAD:tests functional/ installer/ nixos/ ```	2023-10-06 09:05:56 -04:00

Robert Hensing

9b7b7a7561

Revert "Print the value in error: cannot coerce messages (#9553 )"

This reverts commit f0ac2a35d5.

The request from the sibling PR, which also applies here, was not addressed.
https://github.com/NixOS/nix/pull/9554#issuecomment-1845095735

2023-12-09 02:13:32 +01:00

Rebecca Turner

f0ac2a35d5

Print the value in error: cannot coerce messages (#9553 )

* Print the value in `error: cannot coerce` messages

This extends the `error: cannot coerce a TYPE to a string` message
to print the value that could not be coerced. This helps with debugging
by making it easier to track down where the value is being produced
from, especially in errors with deep or unhelpful stack traces.

Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>

2023-12-08 16:36:57 +00:00

John Ericson

68c81c7375

Put functional tests in tests/functional

I think it is bad for these reasons when `tests/` contains a mix of
functional and integration tests

 - Concepts is harder to understand, the documentation makes a good
   unit vs functional vs integration distinction, but when the
   integration tests are just two subdirs within `tests/` this is not
   clear.

 - Source filtering in the `flake.nix` is more complex. We need to
   filter out some of the dirs from `tests/`, rather than simply pick
   the dirs we want and take all of them. This is a good sign the
   structure of what we are trying to do is not matching the structure
   of the files.

With this change we have a clean:
```shell-session
$ git show 'HEAD:tests'
tree HEAD:tests

functional/
installer/
nixos/
```

2023-10-06 09:05:56 -04:00

Renamed from tests/lang/eval-fail-bad-string-interpolation-1.err.exp (Browse further)

3 commits