mirror of
https://github.com/privatevoid-net/nix-super.git
synced 2024-09-21 08:58:04 +03:00
469d06f9bc
This is generally a fine practice: Putting implementations in headers makes them harder to read and slows compilation. Unfortunately it is necessary for templates, but we can ameliorate that by putting them in a separate header. Only files which need to instantiate those templates will need to include the header with the implementation; the rest can just include the declaration. This is now documenting in the contributing guide. Also, it just happens that these polymorphic serializers are the protocol agnostic ones. (Worker and serve protocol have the same logic for these container types.) This means by doing this general template cleanup, we are also getting a head start on better indicating which code is protocol-specific and which code is shared between protocols.
75 lines
2 KiB
C++
75 lines
2 KiB
C++
#pragma once
|
|
/**
|
|
* @file
|
|
*
|
|
* Template implementations (as opposed to mere declarations).
|
|
*
|
|
* This file is an exmample of the "impl.hh" pattern. See the
|
|
* contributing guide.
|
|
*
|
|
* One only needs to include this when one is declaring a
|
|
* `BaseClass<CustomType>` setting, or as derived class of such an
|
|
* instantiation.
|
|
*/
|
|
|
|
#include "config.hh"
|
|
|
|
namespace nix {
|
|
|
|
template<> struct BaseSetting<Strings>::trait
|
|
{
|
|
static constexpr bool appendable = true;
|
|
};
|
|
template<> struct BaseSetting<StringSet>::trait
|
|
{
|
|
static constexpr bool appendable = true;
|
|
};
|
|
template<> struct BaseSetting<StringMap>::trait
|
|
{
|
|
static constexpr bool appendable = true;
|
|
};
|
|
template<> struct BaseSetting<std::set<ExperimentalFeature>>::trait
|
|
{
|
|
static constexpr bool appendable = true;
|
|
};
|
|
|
|
template<typename T>
|
|
struct BaseSetting<T>::trait
|
|
{
|
|
static constexpr bool appendable = false;
|
|
};
|
|
|
|
template<typename T>
|
|
bool BaseSetting<T>::isAppendable()
|
|
{
|
|
return trait::appendable;
|
|
}
|
|
|
|
template<> void BaseSetting<Strings>::appendOrSet(Strings && newValue, bool append);
|
|
template<> void BaseSetting<StringSet>::appendOrSet(StringSet && newValue, bool append);
|
|
template<> void BaseSetting<StringMap>::appendOrSet(StringMap && newValue, bool append);
|
|
template<> void BaseSetting<std::set<ExperimentalFeature>>::appendOrSet(std::set<ExperimentalFeature> && newValue, bool append);
|
|
|
|
template<typename T>
|
|
void BaseSetting<T>::appendOrSet(T && newValue, bool append)
|
|
{
|
|
static_assert(!trait::appendable, "using default `appendOrSet` implementation with an appendable type");
|
|
assert(!append);
|
|
value = std::move(newValue);
|
|
}
|
|
|
|
template<typename T>
|
|
void BaseSetting<T>::set(const std::string & str, bool append)
|
|
{
|
|
if (experimentalFeatureSettings.isEnabled(experimentalFeature))
|
|
appendOrSet(parse(str), append);
|
|
else {
|
|
assert(experimentalFeature);
|
|
warn("Ignoring setting '%s' because experimental feature '%s' is not enabled",
|
|
name,
|
|
showExperimentalFeature(*experimentalFeature));
|
|
}
|
|
}
|
|
|
|
}
|