mirror of
https://github.com/privatevoid-net/nix-super.git
synced 2024-11-16 03:06:17 +02:00
6208ca7209
Most of this is a `catch SysError` -> `catch SystemError` sed. This is a rather pure-churn change I would like to get out of the way. **The intersting part is `src/libutil/error.hh`.** On Unix, we will only throw the `SysError` concrete class, which has the same constructors that `SystemError` used to have. On Windows, we will throw `WinError` *and* `SysError`. `WinError` (which will be created in a later PR), will use a `DWORD` instead of `int` error value, and `GetLastError()`, which is the Windows equivalent of the `errno` machinery. Windows will *also* use `SysError` because Window's "libc" (MSVCRT) implements the POSIX interface, and we use it too. As the docs describe, while we *throw* one of the 3 choices above (2 concrete classes or the alias), we should always *catch* `SystemError`. This ensures no matter how the implementation changes for Windows (e.g. between `SysError` and `WinError`) the catching logic stays the same and stays correct. Co-Authored-By volth <volth@volth.com> Co-Authored-By Eugene Butler <eugene@eugene4.com> |
||
|---|---|---|
| .. | ||
| built-path.cc | ||
| built-path.hh | ||
| command-installable-value.cc | ||
| command-installable-value.hh | ||
| command.cc | ||
| command.hh | ||
| common-eval-args.cc | ||
| common-eval-args.hh | ||
| editor-for.cc | ||
| editor-for.hh | ||
| installable-attr-path.cc | ||
| installable-attr-path.hh | ||
| installable-derived-path.cc | ||
| installable-derived-path.hh | ||
| installable-flake.cc | ||
| installable-flake.hh | ||
| installable-value.cc | ||
| installable-value.hh | ||
| installables.cc | ||
| installables.hh | ||
| legacy.cc | ||
| legacy.hh | ||
| local.mk | ||
| markdown.cc | ||
| markdown.hh | ||
| nix-cmd.pc.in | ||
| repl.cc | ||
| repl.hh | ||