No description
Find a file
Greg Price 7313aa267b installer: Fix terminal colors.
The install-multi-user script uses blue, green, and red colors, as
well as bold and underline, to add helpful formatting that helps
structure its rather voluminous output.

Unfortunately, the terminal escape sequences it uses are not quite
well-formed.  The relevant information is all there, just obscured
by some extra noise, a leading parameter `38`.  Empirically, the
result is:

 * On macOS, in both Terminal.app and iTerm2, the spurious `38` is
   ignored, the rest of the escape sequence is applied, and the colors
   show up as intended.

 * On Linux, in at least gnome-terminal and xterm, the spurious `38`
   and the next parameter after it are ignored, and what's left is
   applied.  So in the sequence `38;4;32`, the 4 (underline) is
   ignored but the 32 (green) takes effect; in a more typical sequence
   like `38;34`, the 34 (blue) is ignored and nothing happens.

These codes are all unchanged since this script's origins as a
Darwin-only script -- so the fact that they work fine in common macOS
terminals goes some way to explain how the bug arose.

Happily, we can make the colors work as intended by just deleting the
extra `38;`.  Tested in all four terminals mentioned above; the new
codes work correctly on all of them, and on the two macOS terminals
they work exactly the same as before.

---

In a bit more technical detail -- perhaps more than anyone, me
included, ever wanted to know, but now that I've gone and learned it
I'll write it down anyway :) -- here's what's happening in these codes:

An ECMA-48 "control sequence" begins with `\033[` aka "CSI", contains
any number of parameters as semicolon-separated decimal numbers (plus
sometimes other wrinkles), and ends with a byte from 0x40..0x7e.  In
our case, with `m` aka "SGR", "Select Graphic Rendition".

An SGR control sequence `\033[...m` sets colors, fonts, text styles,
etc.  In particular a parameter `31` means red, `32` green, `34` blue,
`4` underline, and `0` means reset to normal.  Those are all we use.

There is also a `38`.  This is used for setting colors too... but it
needs arguments.  `38;5;nn` is color nn from a 256-color palette, and
`38;2;rr;gg;bb` has the given RGB values.

There is no meaning defined for `38;1` or `38;34` etc.  On seeing a
parameter `38` followed by an unrecognized argument for it, apparently
some implementations (as seen on macOS) discard only the `38` and
others (as seen on Linux) discard the argument too before resuming.
2020-03-24 21:15:01 -07:00
.github Remove build and binaryTarball since they're included in installerScript 2020-03-13 15:56:25 +01:00
config update config/config.{sub,guess} 2018-08-13 20:00:17 +00:00
contrib function-trace: always show the trace 2019-09-18 23:23:21 +02:00
corepkgs Move some corepkgs into the nix binary 2020-03-11 16:57:48 +01:00
doc/manual doc: Files in the store have modes 444/555, not 644/755 2020-03-23 20:23:27 -07:00
m4 autoconf: Fix C++17 detection not working on Ubuntu 16.04. 2019-07-03 04:32:25 +02:00
maintainers upload-release.pl: Fix sshfs call 2019-09-04 21:44:40 +02:00
misc Make nix-daemon.plist less fragile on macOS 2019-10-09 12:52:01 +01:00
mk mk/README.md: Remove 2020-03-13 14:50:51 +01:00
nix-rust Remove macro_use 2020-02-10 09:03:24 +01:00
perl nix-perl: Fix segfault in queryPathInfo) 2020-03-10 11:00:17 +01:00
scripts installer: Fix terminal colors. 2020-03-24 21:15:01 -07:00
src Misc changes from the flakes branch 2020-03-24 14:34:47 +01:00
tests Misc changes from the flakes branch 2020-03-24 14:34:47 +01:00
.dir-locals.el .dir-locals.el: Set additional lambda indentation to zero 2020-02-20 07:56:35 +01:00
.editorconfig Add .editorconfig 2017-06-05 22:57:28 +01:00
.gitignore Misc changes from the flakes branch 2020-03-24 14:34:47 +01:00
.travis.yml travis: enable linux builds 2019-10-31 16:37:33 +00:00
.version Bump version 2019-09-04 15:59:33 +02:00
bootstrap.sh bootstrap: Simplify & make more robust. 2011-09-06 12:11:05 +00:00
configure.ac Merge branch 'libarchive' of https://github.com/yorickvP/nix 2019-12-19 14:47:18 +01:00
COPYING * Change this to LGPL to keep the government happy. 2006-04-25 16:41:06 +00:00
local.mk Shut up about deprecated functions 2019-12-10 13:44:49 +01:00
Makefile Add some Rust code 2019-11-26 22:07:28 +01:00
Makefile.config.in Misc changes from the flakes branch 2020-03-24 14:34:47 +01:00
precompiled-headers.h Fix macOS build 2019-11-07 11:53:28 +01:00
README.md README.md: Remove reference to OpenSSL 2020-03-13 18:42:53 +01:00
release-common.nix Remove the tarball job 2020-03-13 18:05:22 +01:00
release.nix Remove the 'release' job 2020-03-13 18:34:10 +01:00
shell.nix Remove the tarball job 2020-03-13 18:05:22 +01:00

Open Collective supporters

Nix, the purely functional package manager

Nix is a new take on package management that is fairly unique. Because of its purity aspects, a lot of issues found in traditional package managers don't appear with Nix.

To find out more about the tool, usage and installation instructions, please read the manual, which is available on the Nix website at https://nixos.org/nix/manual.

Contributing

Take a look at the Hacking Section of the manual. It helps you to get started with building Nix from source.

License

Nix is released under the LGPL v2.1