mirror of
https://github.com/privatevoid-net/nix-super.git
synced 2024-11-23 14:36:16 +02:00
c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
66 lines
1.4 KiB
Bash
66 lines
1.4 KiB
Bash
source ./common.sh
|
|
|
|
flake1Dir=$TEST_ROOT/flake1
|
|
flake2Dir=$TEST_ROOT/flake2
|
|
|
|
mkdir -p $flake1Dir $flake2Dir
|
|
|
|
writeSimpleFlake $flake2Dir
|
|
tar cfz $TEST_ROOT/flake.tar.gz -C $TEST_ROOT flake2
|
|
hash=$(nix hash path $flake2Dir)
|
|
|
|
dep=$(nix store add-path ./common.sh)
|
|
|
|
cat > $flake1Dir/flake.nix <<EOF
|
|
{
|
|
inputs.flake2.url = "file://$TEST_ROOT/flake.tar.gz";
|
|
|
|
outputs = { self, flake2 }: {
|
|
|
|
a1 = builtins.fetchTarball {
|
|
#type = "tarball";
|
|
url = "file://$TEST_ROOT/flake.tar.gz";
|
|
sha256 = "$hash";
|
|
};
|
|
|
|
a2 = ./foo;
|
|
|
|
a3 = ./.;
|
|
|
|
a4 = self.outPath;
|
|
|
|
# FIXME
|
|
a5 = self;
|
|
|
|
a6 = flake2.outPath;
|
|
|
|
# FIXME
|
|
a7 = "\${flake2}/config.nix";
|
|
|
|
# This is only allowed in impure mode.
|
|
a8 = builtins.storePath $dep;
|
|
|
|
a9 = "$dep";
|
|
};
|
|
}
|
|
EOF
|
|
|
|
echo bar > $flake1Dir/foo
|
|
|
|
nix build --json --out-link $TEST_ROOT/result $flake1Dir#a1
|
|
[[ -e $TEST_ROOT/result/simple.nix ]]
|
|
|
|
nix build --json --out-link $TEST_ROOT/result $flake1Dir#a2
|
|
[[ $(cat $TEST_ROOT/result) = bar ]]
|
|
|
|
nix build --json --out-link $TEST_ROOT/result $flake1Dir#a3
|
|
|
|
nix build --json --out-link $TEST_ROOT/result $flake1Dir#a4
|
|
|
|
nix build --json --out-link $TEST_ROOT/result $flake1Dir#a6
|
|
[[ -e $TEST_ROOT/result/simple.nix ]]
|
|
|
|
nix build --impure --json --out-link $TEST_ROOT/result $flake1Dir#a8
|
|
diff common.sh $TEST_ROOT/result
|
|
|
|
(! nix build --impure --json --out-link $TEST_ROOT/result $flake1Dir#a9)
|