mirror of
https://github.com/privatevoid-net/nix-super.git
synced 2024-11-11 08:46:16 +02:00
91b6833686
Today, with the tests inside a `tests` intermingled with the
corresponding library's source code, we have a few problems:
- We have to be careful that wildcards don't end up with tests being
built as part of Nix proper, or test headers being installed as part
of Nix proper.
- Tests in libraries but not executables is not right:
- It means each executable runs the previous unit tests again, because
it needs the libraries.
- It doesn't work right on Windows, which doesn't want you to load a
DLL just for the side global variable . It could be made to work
with the dlopen equivalent, but that's gross!
This reorg solves these problems.
There is a remaining problem which is that sibbling headers (like
`hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end
up shadowing each other. This PR doesn't solve that. That is left as
future work for a future PR.
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
23 lines
586 B
Makefile
23 lines
586 B
Makefile
libraries += libexpr-test-support
|
|
|
|
libexpr-test-support_NAME = libnixexpr-test-support
|
|
|
|
libexpr-test-support_DIR := $(d)
|
|
|
|
ifeq ($(INSTALL_UNIT_TESTS), yes)
|
|
libexpr-test-support_INSTALL_DIR := $(checklibdir)
|
|
else
|
|
libexpr-test-support_INSTALL_DIR :=
|
|
endif
|
|
|
|
libexpr-test-support_SOURCES := \
|
|
$(wildcard $(d)/tests/*.cc) \
|
|
$(wildcard $(d)/tests/value/*.cc)
|
|
|
|
libexpr-test-support_CXXFLAGS += $(libexpr-tests_EXTRA_INCLUDES)
|
|
|
|
libexpr-test-support_LIBS = \
|
|
libstore-test-support libutil-test-support \
|
|
libexpr libstore libutil
|
|
|
|
libexpr-test-support_LDFLAGS := -lrapidcheck
|