mirror of
https://github.com/privatevoid-net/nix-super.git
synced 2024-11-10 16:26:18 +02:00
c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
54 lines
2 KiB
Bash
54 lines
2 KiB
Bash
source common.sh
|
|
|
|
clearStore
|
|
|
|
# https://github.com/NixOS/nix/issues/6572
|
|
issue_6572_independent_outputs() {
|
|
nix build -f multiple-outputs.nix --json independent --no-link > $TEST_ROOT/independent.json
|
|
|
|
# Make sure that 'nix build' can build a derivation that depends on both outputs of another derivation.
|
|
p=$(nix build -f multiple-outputs.nix use-independent --no-link --print-out-paths)
|
|
nix-store --delete "$p" # Clean up for next test
|
|
|
|
# Make sure that 'nix build' tracks input-outputs correctly when a single output is already present.
|
|
nix-store --delete "$(jq -r <$TEST_ROOT/independent.json .[0].outputs.first)"
|
|
p=$(nix build -f multiple-outputs.nix use-independent --no-link --print-out-paths)
|
|
cmp $p <<EOF
|
|
first
|
|
second
|
|
EOF
|
|
nix-store --delete "$p" # Clean up for next test
|
|
|
|
# Make sure that 'nix build' tracks input-outputs correctly when a single output is already present.
|
|
nix-store --delete "$(jq -r <$TEST_ROOT/independent.json .[0].outputs.second)"
|
|
p=$(nix build -f multiple-outputs.nix use-independent --no-link --print-out-paths)
|
|
cmp $p <<EOF
|
|
first
|
|
second
|
|
EOF
|
|
nix-store --delete "$p" # Clean up for next test
|
|
}
|
|
issue_6572_independent_outputs
|
|
|
|
|
|
# https://github.com/NixOS/nix/issues/6572
|
|
issue_6572_dependent_outputs() {
|
|
|
|
nix build -f multiple-outputs.nix --json a --no-link > $TEST_ROOT/a.json
|
|
|
|
# # Make sure that 'nix build' can build a derivation that depends on both outputs of another derivation.
|
|
p=$(nix build -f multiple-outputs.nix use-a --no-link --print-out-paths)
|
|
nix-store --delete "$p" # Clean up for next test
|
|
|
|
# Make sure that 'nix build' tracks input-outputs correctly when a single output is already present.
|
|
nix-store --delete "$(jq -r <$TEST_ROOT/a.json .[0].outputs.second)"
|
|
p=$(nix build -f multiple-outputs.nix use-a --no-link --print-out-paths)
|
|
cmp $p <<EOF
|
|
first
|
|
second
|
|
EOF
|
|
nix-store --delete "$p" # Clean up for next test
|
|
}
|
|
if isDaemonNewer "2.12pre0"; then
|
|
issue_6572_dependent_outputs
|
|
fi
|