mirror of
https://github.com/privatevoid-net/nix-super.git
synced 2024-11-14 02:06:16 +02:00
c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
26 lines
837 B
Bash
26 lines
837 B
Bash
source common.sh
|
|
|
|
# Tests miscellaneous commands.
|
|
|
|
# Do all commands have help?
|
|
#nix-env --help | grepQuiet install
|
|
#nix-store --help | grepQuiet realise
|
|
#nix-instantiate --help | grepQuiet eval
|
|
#nix-hash --help | grepQuiet base32
|
|
|
|
# Can we ask for the version number?
|
|
nix-env --version | grep "$version"
|
|
|
|
# Usage errors.
|
|
expect 1 nix-env --foo 2>&1 | grep "no operation"
|
|
expect 1 nix-env -q --foo 2>&1 | grep "unknown flag"
|
|
|
|
# Eval Errors.
|
|
eval_arg_res=$(nix-instantiate --eval -E 'let a = {} // a; in a.foo' 2>&1 || true)
|
|
echo $eval_arg_res | grep "at «string»:1:15:"
|
|
echo $eval_arg_res | grep "infinite recursion encountered"
|
|
|
|
eval_stdin_res=$(echo 'let a = {} // a; in a.foo' | nix-instantiate --eval -E - 2>&1 || true)
|
|
echo $eval_stdin_res | grep "at «stdin»:1:15:"
|
|
echo $eval_stdin_res | grep "infinite recursion encountered"
|
|
|