mirror of
https://github.com/privatevoid-net/nix-super.git
synced 2024-11-15 18:56:16 +02:00
c6a89c1a16
While preparing PRs like #9753, I've had to change error messages in dozens of code paths. It would be nice if instead of EvalError("expected 'boolean' but found '%1%'", showType(v)) we could write TypeError(v, "boolean") or similar. Then, changing the error message could be a mechanical refactor with the compiler pointing out places the constructor needs to be changed, rather than the error-prone process of grepping through the codebase. Structured errors would also help prevent the "same" error from having multiple slightly different messages, and could be a first step towards error codes / an error index. This PR reworks the exception infrastructure in `libexpr` to support exception types with different constructor signatures than `BaseError`. Actually refactoring the exceptions to use structured data will come in a future PR (this one is big enough already, as it has to touch every exception in `libexpr`). The core design is in `eval-error.hh`. Generally, errors like this: state.error("'%s' is not a string", getAttrPathStr()) .debugThrow<TypeError>() are transformed like this: state.error<TypeError>("'%s' is not a string", getAttrPathStr()) .debugThrow() The type annotation has moved from `ErrorBuilder::debugThrow` to `EvalState::error`. |
||
|---|---|---|
| .. | ||
| child.cc | ||
| child.hh | ||
| derivation-goal.cc | ||
| derivation-goal.hh | ||
| drv-output-substitution-goal.cc | ||
| drv-output-substitution-goal.hh | ||
| entry-points.cc | ||
| goal.cc | ||
| goal.hh | ||
| hook-instance.cc | ||
| hook-instance.hh | ||
| local-derivation-goal.cc | ||
| local-derivation-goal.hh | ||
| personality.cc | ||
| personality.hh | ||
| sandbox-defaults.sb | ||
| sandbox-minimal.sb | ||
| sandbox-network.sb | ||
| substitution-goal.cc | ||
| substitution-goal.hh | ||
| worker.cc | ||
| worker.hh | ||