16154 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
John Ericson	4687beecef	Get rid of CanonPath::fromCwd ... As discussed in the last Nix team meeting (2024-02-95), this method doesn't belong because `CanonPath` is a virtual/ideal absolute path format, not used in file systems beyond the native OS format for which a "current working directory" is defined. Progress towards #9205	2024-02-08 11:01:41 -05:00
John Ericson	f2f54cf087	Merge pull request #9863 from obsidiansystems/perl-open-other-store ... Support arbitrary stores in Perl bindings	2024-02-08 09:30:18 -05:00
Théophane Hufschmitt	46a0625a40	Merge pull request #9929 from 9999years/dont-print-values-in-magenta ... Don't print the first bracket in values in magenta in error messages	2024-02-08 10:56:18 +01:00
Théophane Hufschmitt	9b8b486091	Merge pull request #9933 from pennae/debugger-fix ... fix debugger crashing while printing envs	2024-02-08 10:48:02 +01:00
Théophane Hufschmitt	acef4f17a2	Merge pull request #9918 from 9999years/debugger-locals-for-let-expressions ... Expose locals from `let` expressions to the debugger	2024-02-08 10:17:55 +01:00
Théophane Hufschmitt	c4ed92fa6f	Merge pull request #9917 from 9999years/enter-debugger-more-reliably ... Enter debugger more reliably in `let` expressions and function calls	2024-02-08 10:09:54 +01:00
Théophane Hufschmitt	fb78a99e04	Merge pull request #9924 from 9999years/rename-yellowtxt ... Rename `yellowtxt` -> `magentatxt`	2024-02-08 10:01:30 +01:00
Théophane Hufschmitt	f388a6148d	Merge pull request #9919 from 9999years/reduce-debugger-clutter ... Reduce visual clutter in the debugger	2024-02-08 09:42:38 +01:00
Théophane Hufschmitt	d24c8aa491	Simplify a conditional in the repl initialisation	2024-02-08 09:22:30 +01:00
John Ericson	bc08502249	Support arbitrary stores in Perl bindings ... Fix #9859 It's a breaking change but that's fine; we can just update Hydra to use the new bindings.	2024-02-07 22:31:58 -05:00
Eelco Dolstra	09a6e8e703	Merge pull request #9949 from fricklerhandwerk/fix-redirects-file ... fix location of `_redirects` file	2024-02-07 11:34:35 +01:00
Valentin Gagarin	2d74b56aee	fix location of _redirects file ... the Netlify `_redirects` file must be in the root directory [0] of the files to serve, and mdBook copies all the files in `src` that aren't `.md` to the output directory [1]. [0]: https://docs.netlify.com/routing/redirects/ [1]: https://rust-lang.github.io/mdBook/guide/creating.html#source-files	2024-02-06 23:22:34 +01:00
Rebecca Turner	155bc761f6	Add release note	2024-02-05 13:16:39 -08:00
Rebecca Turner	b63a8d7c46	Add release note	2024-02-05 13:15:29 -08:00
Rebecca Turner	601fc7d159	Add release note	2024-02-05 13:13:26 -08:00
Robert Hensing	a31f2cb0cd	Merge pull request #9939 from edolstra/slash-operator ... CanonPath, SourcePath: Change operator + to /	2024-02-05 15:55:27 +01:00
Eelco Dolstra	a6737b7e17	CanonPath, SourcePath: Change operator + to / ... This is less confusing and makes it more similar to std::filesystem::path.	2024-02-05 15:17:39 +01:00
Eelco Dolstra	c291d2d8dd	Merge pull request #9927 from 9999years/catch-error-in-value-printer ... Catch `Error`, not `BaseError` in `ValuePrinter`	2024-02-05 15:01:21 +01:00
Eelco Dolstra	6ec08b85f6	Merge pull request #9934 from nmeum/absPath-out-of-bounds ... absPath: Explicitly check if path is empty before accessing it	2024-02-05 14:44:02 +01:00
Eelco Dolstra	e190c20c33	Merge pull request #9926 from 9999years/fix-cycle-detection-in-nix-repl ... Fix cycle detection in `nix repl`	2024-02-05 14:24:28 +01:00
Valentin Gagarin	8d4890c3f8	catch multiple use of link reference (#9937)	2024-02-04 21:45:10 +00:00
Valentin Gagarin	8b873edcca	fix anchor link; less weird link texts (#9936)	2024-02-04 21:15:20 +00:00
Valentin Gagarin	721fddac2f	use the right heading level (#9935)	2024-02-04 21:03:13 +00:00
Théophane Hufschmitt	25385a408e	Merge pull request #9930 from rvl/print-dev-env-unbound-variables ... print-dev-env: Avoid using unbound shellHook variable	2024-02-04 20:55:17 +01:00
pennae	5ccb06ee1b	fix debugger crashing while printing envs ... fixes #9932	2024-02-04 17:12:04 +01:00
Rodney Lorrimar	e1131b5927	print-dev-env: Avoid using unbound shellHook variable ... Some tools which consume the "nix print-dev-env" rc script (such as "nix-direnv") are sensitive to the use of unbound variables. They use "set -u". The "nix print-dev-env" rc script initially unsets "shellHook", then loads variables from the derivation, and then evaluates "shellHook". However, most derivations don't have a "shellHook" attribute. So users get the error "shellHook: unbound variable". This can be demonstrated with the command: nix print-dev-env nixpkgs#hello | bash -u This commit changes the rc script to provide an empty fallback value for the "shellHook" variable. Closes: #7951 #8253	2024-02-04 13:57:13 +08:00
Rebecca Turner	770d2bc779	Key repeated values on attribute binding pointers, not value pointers ... Closes #8672	2024-02-03 21:23:06 -08:00
Rebecca Turner	9646d62b0c	Don't print values in magenta ... This fixes the opening bracket of lists/attrsets being printed in magenta, unlike the closing bracket. https://github.com/NixOS/nix/pull/9753#issuecomment-1904616088	2024-02-03 21:17:22 -08:00
Rebecca Turner	a7927abdc1	Catch Error, not BaseError in ValuePrinter ... `BaseError` includes `Interrupt`. We probably don't want the value printer to tell you you pressed Ctrl-C while it was working.	2024-02-03 19:29:07 -08:00
Rebecca Turner	a7939a6c2a	Rename yellowtxt -> magentatxt ... `yellowtxt` wraps its value with `ANSI_WARNING`, but `ANSI_WARNING` has been equal to `ANSI_MAGENTA` for a long time. Now the name is updated.	2024-02-03 19:28:11 -08:00
Sören Tempel	ec5cc1026d	absPath: Explicitly check if path is empty before accessing it ... It is entirely possible for the path to be an empty string and many unit tests actually pass it as an empty string (e.g. both_roundrip or turnsEmptyPathIntoCWD). In this case, without this patch, absPath will perform a one-byte out-of-bounds access. This was discovered while enabling the nix test suite on Alpine where we compile all software with `-D_GLIBCXX_ASSERTIONS=1`, thus resulting in a test failure on Alpine.	2024-02-04 00:47:47 +01:00
Eelco Dolstra	49cf090cb2	Merge pull request #9913 from 9999years/debugger-positions ... Print positions in `--debugger`, instead of pointers	2024-02-03 09:27:09 +01:00
Rebecca Turner	6414cd259e	Reduce visual clutter in the debugger	2024-02-02 19:58:35 -08:00
Rebecca Turner	36dfac7560	Expose locals from let expressions to the debugger	2024-02-02 19:31:18 -08:00
Rebecca Turner	0127d54d5e	Enter debugger more reliably in let expressions and calls	2024-02-02 19:14:22 -08:00
Rebecca Turner	7d7483cafc	Print positions in --debugger, instead of pointers	2024-02-02 17:38:46 -08:00
Eelco Dolstra	081dc5daa1	Merge pull request #9902 from NixOS/require-fixed-output-fetchurl ... builtin:fetchurl: Ensure a fixed-output derivation	2024-02-02 14:00:34 +01:00
Eelco Dolstra	e67458e5b8	Better test fix	2024-02-02 13:34:56 +01:00
Eelco Dolstra	05535be03a	Fix test	2024-02-02 13:07:08 +01:00
Eelco Dolstra	b8b739e484	builtin:fetchurl: Get output hash info from the drv	2024-02-01 22:01:02 +01:00
Eelco Dolstra	1ee42c5b88	builtin:fetchurl: Ensure a fixed-output derivation ... Previously we didn't check that the derivation was fixed-output, so you could use builtin:fetchurl to impurely fetch a file.	2024-02-01 21:46:01 +01:00
Eelco Dolstra	ef6d055ace	Merge pull request #9896 from hercules-ci/tidy-tidy ... Disable a slightly annoying clang-tidy check	2024-02-01 09:02:46 +01:00
Robert Hensing	58c26dd0f0	Add .clang-tidy	2024-02-01 01:01:39 +01:00
Robert Hensing	0f2e9e6bd2	Typo	2024-02-01 01:01:04 +01:00
Robert Hensing	4072a8fea0	Merge pull request #9867 from hercules-ci/issue-912 ... #912 allow leading period	2024-01-31 19:10:59 +01:00
Robert Hensing	7c9ed1b1a3	Merge pull request #9890 from obsidiansystems/remove-unneeded-toRealPath ... Change an `allowPath` call to take a store path again	2024-01-31 18:45:19 +01:00
Robert Hensing	f1b4663805	Disallow store path names that are . or .. (plus opt. -) ... As discussed in the maintainer meeting on 2024-01-29. Mainly this is to avoid a situation where the name is parsed and treated as a file name, mostly to protect users. .-* and ..-* are also considered invalid because they might strip on that separator to remove versions. Doesn't really work, but that's what we decided, and I won't argue with it, because .-* probably doesn't seem to have a real world application anyway. We do still permit a 1-character name that's just "-", which still poses a similar risk in such a situation. We can't start disallowing trailing -, because a non-zero number of users will need it and we've seen how annoying and painful such a change is. What matters most is preventing a situation where . or .. can be injected, and to just get this done.	2024-01-31 18:35:19 +01:00
Robert Hensing	8406da2877	test: Generate distinct hashes ... Gen::just is the constant generator. Don't just return that!	2024-01-31 18:35:19 +01:00
Robert Hensing	69bbd5852a	test: Generate distinct path names ... Gen::just is the constant generator. Don't just return that!	2024-01-31 18:35:19 +01:00
Robert Hensing	b13e6a76b4	parseStorePath: Support leading period	2024-01-31 18:35:19 +01:00