John Ericson
d3c125e5a8
Apply suggestions from code review
...
Thanks!
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-05-09 12:45:51 -04:00
John Ericson
6513f4fe92
Fix bug, newInfo
-> newInfo0
...
It appears we were checking a variable in the process of definining it.
2023-05-09 12:31:36 -04:00
John Ericson
35dcbe1c21
Fix spurious change
...
Didn't mean to use the private name that shouldn't be exposed.
2023-05-09 12:19:03 -04:00
John Ericson
aacde38d2c
Merge pull request #8110 from aakropotkin/quote-reserved
...
Quote reserved keywords when printing expressions
2023-05-09 11:42:44 -04:00
Alex Ameen
82d1d74a85
quote subshell expansion in tests/eval.sh
2023-05-09 10:06:26 -05:00
Alex Ameen
82296f8113
prevent double quotation
2023-05-09 09:59:18 -05:00
Alex Ameen
b72bc4a972
libexpr: quote reserved keys when printing
...
This fixes a bug in commands like `nix eval' which would emit invalid attribute
sets if they contained reserved keywords such as "assert", "let", etc.
These keywords will not be quoted when printed, making them valid expressions.
All keywords recognized by the lexer are quoted except "or", which does not
require quotation.
2023-05-09 09:45:12 -05:00
John Ericson
e7c3399ed2
Specialize LocalOverlayStore::queryPathFromHashPart
...
With test
2023-05-09 10:40:10 -04:00
John Ericson
ddaf2750b5
Specialize more methods, fix tests
2023-05-09 10:22:38 -04:00
John Ericson
b3d320c594
Convert more methods
...
Fixed one test, broke another
2023-05-08 18:50:16 -04:00
John Ericson
59a8099038
Fix LocalOverlayStore::queryPathInfoUncached
, FIXME in test
2023-05-08 17:37:40 -04:00
John Ericson
5406256d78
Specialize LocalOverlayStore::queryPathInfoUncached
2023-05-08 17:30:17 -04:00
John Ericson
31e98ed0a0
Specialize LocalOverlayStore::registerDrvOutput
2023-05-08 16:48:55 -04:00
John Ericson
0193c2abcd
Improve tests slightly
2023-05-08 16:03:32 -04:00
John Ericson
d80fc2ac1b
First round of testing, with todos
2023-05-08 16:01:36 -04:00
John Ericson
9c9f5f0d12
Merge branch 'best-effort-supplementary-groups' into overlayfs-store
2023-05-08 14:47:46 -04:00
John Ericson
f08754a97a
Progress on tests
2023-05-08 14:47:39 -04:00
Matej Urbas
13185133bc
introduces Goal::jobCategory
2023-05-08 19:45:46 +01:00
John Ericson
6d1aa523de
Create escape hatch for supplementary group sandboxing woes
...
There is no obvious good solution for this that has occured to anyone.
2023-05-08 14:41:47 -04:00
Matej Urbas
1ea1e378de
removes MaxSubstitutionJobsSetting
2023-05-08 19:21:57 +01:00
Robert Hensing
4539ab530a
Merge pull request #8296 from fricklerhandwerk/contributing-idea-approved
...
highlight 'idea approved' issues in contributing guide
2023-05-08 17:00:23 +02:00
John Ericson
b5d9ef0a4c
Merge pull request #3921 from obsidiansystems/trustless-remote-builder-simple
...
Trustless remote building for input-addressed drvs
2023-05-08 10:43:37 -04:00
John Ericson
d5fe828d76
Merge remote-tracking branch 'upstream/master' into overlayfs-store
2023-05-08 10:20:18 -04:00
John Ericson
f0a176e2f1
Init local overlay store
2023-05-08 10:20:06 -04:00
John Ericson
df53a7d268
Split comment, match with each variable
2023-05-08 10:08:01 -04:00
John Ericson
cd0d8e0bd5
Apply suggestions from code review
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-05-08 09:57:05 -04:00
John Ericson
278c94d607
Rename a few things in new tests
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-05-08 08:01:58 -04:00
Yorick van Pelt
d1ff33d2d6
tests/post-hook: remove TODO and --derivation upload
2023-05-08 12:58:59 +02:00
Yorick van Pelt
5e332aa503
tests: copying only the out paths is not enough information for CA
2023-05-08 12:58:59 +02:00
Yorick van Pelt
12685ef45f
CA: rewrite hashes for all outputs, not just the wanted ones
2023-05-08 12:58:59 +02:00
Yorick van Pelt
2ca2c80c4e
libstore: also pass unwanted outputs to the post-build-hook
2023-05-08 12:58:59 +02:00
Yorick van Pelt
869fb1a2f6
tests/post-hook: test to see if all outputs are passed
...
fe5509df
caused only wanted outputs to be passed to the
post-build-hook, which resulted in paths being built
without ever going into the hook.
This commit adds a (currently failing) test for this.
2023-05-08 12:43:56 +02:00
Robert Hensing
cf8effdae2
Merge pull request #8263 from frederictobiasc/improve-doc-genericclosure
...
Documentation: Improve builtins.genericClosure
2023-05-08 12:23:19 +02:00
Robert Hensing
879e45247c
Merge pull request #8288 from figsoda/regex
...
Fix hostRegex to accept hosts with a `-`
2023-05-08 12:14:59 +02:00
Matej Urbas
613bc699bb
max-substitution-jobs
setting
2023-05-07 20:22:18 +01:00
Valentin Gagarin
7c03285719
Update CONTRIBUTING.md
...
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2023-05-06 14:24:49 +02:00
Valentin Gagarin
0fad8f71c4
highlight 'idea approved' issues in contributing guide
2023-05-05 14:15:29 +02:00
Théophane Hufschmitt
81778c8d55
Merge pull request #6953 from EzraSingh/patch-1
...
Update install-systemd-multi-user.sh
2023-05-05 13:20:22 +02:00
figsoda
0662fd8599
Fix hostRegex to accept hosts with a -
2023-05-03 18:59:44 -04:00
Eelco Dolstra
b17c4290cf
Merge pull request #8286 from fricklerhandwerk/uninstall-redirects
...
add redirect to track moved uninstall section
2023-05-03 14:09:33 +02:00
Valentin Gagarin
dc8191ae14
add redirect to track moved uninstall section
2023-05-03 11:39:29 +02:00
Valentin Gagarin
5d78dc4176
doc rendering: add functions to scope explicitly ( #7378 )
...
* doc rendering: add functions to scope explicitly
this especially helps beginners with code readability, since the origin
of names is always immediately visible.
2023-05-03 07:16:29 +00:00
Théophane Hufschmitt
1540ab7628
Merge pull request #8282 from fricklerhandwerk/idea-approved
...
maintainers: add procedure for 'idea approved' label
2023-05-02 16:34:01 +02:00
Eelco Dolstra
ba180d7d89
Merge pull request #8270 from edolstra/nix-repair
...
nix: Support the --repair flag
2023-05-02 12:54:08 +02:00
Valentin Gagarin
feb2200ba6
use headings instead of list items
...
this allows easier linking and a provides a bit more visual clarity
2023-05-02 11:30:27 +02:00
Valentin Gagarin
521cca1840
add procedure for 'idea approved' label
2023-05-02 11:28:03 +02:00
Eelco Dolstra
17e6b85d05
nix: Support the --repair flag
2023-04-28 17:03:04 +02:00
Eelco Dolstra
89d3cc5a47
Merge pull request #8267 from fricklerhandwerk/uninstall-instructions
...
move uninstall instructions to a separate page
2023-04-28 12:41:09 +02:00
Valentin Gagarin
f8620758aa
display documentation on manifest files separately
...
it's probably better not to show the manifest file documentation in the
command-specific pages, because these are implementation details that are not really practically useful.
this means no additional hassle for building the manual, but clutters
the table of contents a bit.
2023-04-28 12:10:36 +02:00
Valentin Gagarin
9b2a4a4729
move uninstall instructions to a separate page
...
placed in a subsection of the binary install, the instructions are hard
to find. putting them in a separate page that is shown in the table of
contents should make it easier for users to find what they need when
they need it.
2023-04-28 11:53:38 +02:00