aszlig
8b88d25cda
libutil: Limit readLink() error to only overflows.
...
Let's not just improve the error message itself, but also the behaviour
to actually work around the ntfs-3g symlink bug. If the readlink() call
returns a smaller size than the stat() call, this really isn't a problem
even if the symlink target really has changed between the calls.
So if stat() reports the size for the absolute path, it's most likely
that the relative path is smaller and thus it should also work for file
system bugs as mentioned in 93002d69fc58c2b71e2dfad202139230c630c53a.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Tested-by: John Ericson <Ericson2314@Yahoo.com>
2015-01-02 12:53:42 +01:00
aszlig
bbd45ac80f
libutil: Improve errmsg on readLink size mismatch.
...
A message like "error: reading symbolic link `...' : Success" really is
quite confusing, so let's not indicate "success" but rather point out
the real issue.
We could also limit the check of this to just check for non-negative
values, but this would introduce a race condition between stat() and
readlink() if the link target changes between those two calls, thus
leading to a buffer overflow vulnerability.
Reported by @Ericson2314 on IRC. Happened due to a possible ntfs-3g bug
where a relative symlink returned the absolute path (st_)size in stat()
while readlink() returned the relative size.
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Tested-by: John Ericson <Ericson2314@Yahoo.com>
2015-01-02 12:53:42 +01:00
Eelco Dolstra
411b237ee5
edition -> subtitle
...
For some reason, docbook-xsl doesn't render edition.
2015-01-02 12:53:32 +01:00
Shea Levy
3d97b8d1e7
LocalStore initialization: Don't die if build-users-group doesn't exist
...
See NixOS/nixpkgs@9245516
2014-12-29 14:40:13 +01:00
Eelco Dolstra
bd0f362d2f
Revive running builds in a PID namespace
2014-12-23 17:25:06 +01:00
Eelco Dolstra
f16b8786a2
Belatedly add contributors
2014-12-16 18:58:04 +01:00
Eelco Dolstra
2162a9c1c7
Bump version number
2014-12-15 18:05:56 +01:00
Eelco Dolstra
ccde347eb8
Merge pull request #420 from linquize/cygwin
...
Add exe, dll to .gitignore
2014-12-15 16:38:05 +01:00
Linquize
4579a44617
Add exe, dll to .gitignore
2014-12-15 23:34:13 +08:00
Eelco Dolstra
c2384052e3
Grmbl
2014-12-14 03:38:54 +01:00
Eelco Dolstra
47ed06a290
Add a section on nix-serve
2014-12-14 03:37:41 +01:00
Eelco Dolstra
2142f47c06
Add section on SSH substituter
2014-12-14 03:19:15 +01:00
Eelco Dolstra
4e0607369e
Pedantry
2014-12-14 01:51:14 +01:00
Eelco Dolstra
8bdff8c100
Merge branch 'cygwin-master' of https://github.com/ternaris/nix
2014-12-14 01:49:14 +01:00
Eelco Dolstra
14955c297d
Merge commit '36c67860363c93eb00cf5b8e2ad34f6f775e6901'
2014-12-14 01:47:06 +01:00
Eelco Dolstra
68b4717873
Delete the stdenv section
...
It's outdated and better covered in the Nixpkgs manual.
2014-12-14 01:39:32 +01:00
Eelco Dolstra
6466d56f42
Bla
2014-12-14 01:33:16 +01:00
Eelco Dolstra
e90e7b5e0a
Fix build
...
http://hydra.nixos.org/build/17894500
2014-12-14 01:29:35 +01:00
Eelco Dolstra
eb53f592b8
Fix image in PDF
...
Closes #415 .
2014-12-14 01:23:06 +01:00
Eelco Dolstra
9c830394ec
Rename files
2014-12-14 01:07:23 +01:00
Eelco Dolstra
4c4e891652
Update .nixpkg description
2014-12-13 23:27:22 +01:00
Eelco Dolstra
be79773542
ReiserFS -> ext4
2014-12-13 23:23:19 +01:00
Eelco Dolstra
4eace5adda
Style
2014-12-13 23:21:14 +01:00
Eelco Dolstra
751ae181a1
Undocument nix-generate-patches
2014-12-13 23:17:26 +01:00
Eelco Dolstra
3b88d03714
Document channel format and excise most mentions of manifests and nix-pull
2014-12-13 23:16:08 +01:00
Eelco Dolstra
e5a51fab24
Style
2014-12-13 21:50:01 +01:00
Eelco Dolstra
fa2063ca35
Better error message
2014-12-13 16:54:40 +01:00
Eelco Dolstra
c2a552b075
Install cacert before running nix-channel
...
Also, make it more robust against incorrent SSL_CERT_FILE values.
2014-12-13 16:53:21 +01:00
Eelco Dolstra
b77037b8fd
Silence some warnings on GCC 4.9
2014-12-12 17:14:28 +01:00
Eelco Dolstra
46f3eb6fdd
Shut up a Valgrind warning
2014-12-12 15:10:02 +01:00
Eelco Dolstra
f52b6c944e
Fix some memory leaks
2014-12-12 15:01:16 +01:00
Eelco Dolstra
28f22b4653
Ensure we're writing to stderr in the builder
...
http://hydra.nixos.org/build/17862041
2014-12-12 14:35:44 +01:00
Eelco Dolstra
5a2d451648
Don't abort if we get a signal while waiting for the pager
2014-12-12 14:05:23 +01:00
Eelco Dolstra
54616be64f
Get rid of unnecessary "interrupted by the user" message with -vvv
2014-12-12 14:01:14 +01:00
Eelco Dolstra
4acca1a5b9
Remove chatty message
...
This broke building with "-vv", because the builder is not allowed to
write to stderr at this point.
2014-12-12 13:43:59 +01:00
Eelco Dolstra
ad790022fd
Doh
2014-12-12 13:41:00 +01:00
Eelco Dolstra
dcdb254281
Remove tabs
2014-12-12 12:39:50 +01:00
Eelco Dolstra
df319047f4
Remove dead code
2014-12-12 12:30:38 +01:00
Eelco Dolstra
8aedaf111e
Remove canary stuff
2014-12-12 10:59:50 +01:00
Eelco Dolstra
a144eb1415
Don't use ?=
2014-12-11 10:44:02 +01:00
darealshinji
40e1203abc
allow custom docbook paths/URLs, use a working URL for docbook.rng
2014-12-11 10:43:46 +01:00
Eelco Dolstra
6f8ff8564f
Urgh
2014-12-11 09:58:29 +01:00
Eelco Dolstra
c56bfbe863
Provide default pagers
...
Borrowed from systemd.
2014-12-10 18:16:05 +01:00
Eelco Dolstra
851b47bd7d
Don't do vfork in conjunction with setuid
2014-12-10 18:01:01 +01:00
Eelco Dolstra
0e8fc118b3
Use vfork
2014-12-10 17:25:39 +01:00
Eelco Dolstra
b5ed5b6e66
Rename function
2014-12-10 17:25:38 +01:00
Eelco Dolstra
20cf0127f5
Include cacert in the binary tarball
...
This prevents having to fetch Nixpkgs or cacert over http.
2014-12-10 16:05:08 +01:00
Eelco Dolstra
e529823635
Don't wait for PID -1
...
The pid field can be -1 if forking the substituter process failed.
2014-12-10 13:53:04 +01:00
Eelco Dolstra
ad332e1718
Revert "Use posix_spawn to run the pager"
...
This reverts commit d34d2b2bbf
2014-12-10 13:48:50 +01:00
Eelco Dolstra
36c6786036
Cruft
2014-12-10 13:01:28 +01:00
