nix-super/mk
John Ericson c11836126b Harden tests' bash
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.

 - `set -u` catches the use of undefined variables
 - `set -o pipefail` catches failures (like `set -e`) earlier in the
   pipeline.

This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.

There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.

To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.

`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.

`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.

`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-03-08 10:26:30 -05:00
..
clean.mk Add 'mk/' from commit '1eff3ad37fdb9dcf9f8528fdacea0ebf0e79d545' 2014-02-01 14:38:28 +01:00
common-test.sh Make ./mk/run-test.sh work by itself; add mk/debug-test.sh 2022-12-21 02:28:33 -05:00
debug-test.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
disable-tests.mk Add ./configure --disable-tests option 2023-02-24 09:50:21 +01:00
functions.mk Revert "Get rid of unicode quotes (#1140)" 2016-11-26 00:38:01 +01:00
install.mk Sync with make-rules repo 2014-04-03 17:37:14 +02:00
lib.mk Apply OS checks to host platform, not build 2021-06-23 15:00:36 +00:00
libraries.mk Fix static build 2023-02-14 15:54:19 +01:00
patterns.mk mk: add support for CPPFLAGS 2021-02-26 22:56:51 +00:00
precompiled-headers.mk mk/precompiled-headers.mk: Remove special handling for clang 2020-10-06 13:27:09 +02:00
programs.mk Fix static build 2023-02-14 15:54:19 +01:00
run-test.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
templates.mk Revert "Get rid of unicode quotes (#1140)" 2016-11-26 00:38:01 +01:00
tests.mk Make ./mk/run-test.sh work by itself; add mk/debug-test.sh 2022-12-21 02:28:33 -05:00
tracing.mk Revert "Add support for building JARs from Java sources" 2021-02-26 23:06:58 +00:00